https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Bug ID: 1321902 Summary: Review Request: qt5ct - Qt5 Configuration Tool Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lupinix@mailbox.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://lupinix.fedorapeople.org/review/qt5ct.spec SRPM URL: https://lupinix.fedorapeople.org/review/qt5ct-0.22-1.fc23.src.rpm
Description: qt5ct allows users to configure Qt5 settings (theme, font, icons, etc.) under DE/WM without Qt integration.
Fedora Account System Username: lupinix
Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13494152
Thank you very much for review in advance!
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Christian Dersch lupinix@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |928937 (qt-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Christian Dersch lupinix@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |qt5ct
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #1 from Christian Dersch lupinix@mailbox.org --- New Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13494545
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Christian Dersch lupinix@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Trivial
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #2 from Christian Dersch lupinix@mailbox.org --- New Koji build to reflect current spec status: http://koji.fedoraproject.org/koji/taskinfo?taskID=13495637
Change: Added BuildRequires: gcc-c++ required by https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Req...
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu
--- Comment #3 from Rex Dieter rdieter@math.unl.edu --- Thanks for working on this, been meaning to look into it myself for awhile.
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Michael Cullen michael@cullen-online.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@cullen-online.com
--- Comment #4 from Michael Cullen michael@cullen-online.com --- Completely UNOFFICIAL comments following:
* the Source0 URL is not a direct link to the tarball (it goes to sourceforge's redirect page) => https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#So... suggests
Source0: http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar....
* 0.23 just came out (minor point since it came out after this was submitted) * Package installs and seems to run correctly
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
--- Comment #5 from Rex Dieter rdieter@math.unl.edu --- I can do a formal review today.
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- naming: ok
sources: ok 28af9b3aa030fb31c00932453e59f635 qt5ct-0.22.tar.bz2
though I agree per comment #4 above, 1. SHOULD update URL to match SourceURL guidelines for sourceforge projects
license: ok
macros: mostly ok 2. SHOULD: %make_install should be used only for autoconf-based packages, use instead: make install INSTALL_ROOT=%{buildroot}
scriptlets: NOT ok 3. SHOULD remove not-needed ldconfig and icon scriptlets. This package contains neither any shared libraries or icons.
I don't see any blockers, but please consider addressing those 3 SHOULD items prior to doing any official builds.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #7 from Christian Dersch lupinix@mailbox.org --- Done, thank you for reviewing :) I'll also import the new version 0.23 released some days ago.
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5ct
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-19c9d2ffbf
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-002673fb41
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-93684d7e11
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-64b17587f7
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-19c9d2ffbf
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-05-07 07:39:51
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-93684d7e11
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-002673fb41
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-64b17587f7
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-05-07 07:39:51 |2016-05-20 19:51:49
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1321902
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- qt5ct-0.23-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org