Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lmacken@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://people.redhat.com/lmacken/SPECS/TurboCheetah.spec SRPM URL: http://people.redhat.com/lmacken/RPMS/TurboCheetah-0.9.5-1.src.rpm Description: This package provides a template engine plugin, allowing you to easily use Cheetah with TurboGears, Buffet and other tools that support the python.templating.engines entry point.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |189338 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|Package Review |orpie
------- Additional Comments From lmacken@redhat.com 2006-09-30 02:47 EST ------- http://people.redhat.com/lmacken/SPECS/python-turbocheetah.spec http://people.redhat.com/lmacken/RPMS/python-turbocheetah-0.9.5-2.src.rpm
* Sat Sep 30 2006 Luke Macken lmacken@redhat.com - 0.9.5-2 - Rename to python-turbocheetah - Install egg-info - Add README
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|orpie |Package Review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@math.uh.edu
------- Additional Comments From tibbs@math.uh.edu 2006-10-06 01:04 EST ------- This failed to build for me in mock:
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.30074 [...] + /usr/bin/python setup.py build Traceback (most recent call last): File "setup.py", line 1, in ? from setuptools import setup, find_packages ImportError: No module named setuptools error: Bad exit status from /var/tmp/rpm-tmp.30074 (%build)
Adding a BR: python-setuptools gets things building.
rpmlint only says: W: python-turbocheetah mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 18)
Is it actually possible to run any of those tests, or do they just clutter things up needlessly?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|Package Review |p0rn-comfort
------- Additional Comments From lmacken@redhat.com 2006-10-06 15:43 EST ------- The script in the tests directory doesn't even have a main method, so they're pretty much just adding clutter, so I removed them.
http://people.redhat.com/lmacken/RPMS/python-turbocheetah-0.9.5-3.src.rpm http://people.redhat.com/lmacken/SPECS/python-turbocheetah.spec
* Fri Oct 6 2006 Luke Macken lmacken@redhat.com - 0.9.5-3 - Add python-setuptools to BuildRequires - Remove tests directory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|p0rn-comfort |Package Review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
------- Additional Comments From tibbs@math.uh.edu 2006-10-09 22:46 EST ------- Oops, I guess I took too long to get back to this, because 0.9.5 is now unavailable. At least, when I try to fetch the source, I'm redirected to a page that tells me that the preview is over. But I don't actually see a place to download TurboCheetah separately, except as eggs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
------- Additional Comments From lmacken@redhat.com 2006-10-09 22:54 EST ------- Ah, the Source0 in the spec is wrong (I'll fix it up for the next revision). I pulled down the tarballs for 0.9.5 from the Cheese Shop:
http://cheeseshop.python.org/pypi/TurboCheetah
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
------- Additional Comments From tibbs@math.uh.edu 2006-10-09 23:34 EST ------- Ah, OK. I changed Source0 to http://cheeseshop.python.org/packages/source/T/TurboCheetah/TurboCheetah-%%7...
The one remaining issue I see is that this package needs to own /usr/lib/python2.4/site-packages/turbocheetah.
* source files match upstream: 52e12130302a218a8e3b925447041be4 TurboCheetah-0.9.5.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: python-turbocheetah = 0.9.5-3.fc6 = python(abi) = 2.4 python-cheetah >= 1.0 * %check is not present; tests not runnable. X needs to own /usr/lib/python2.4/site-packages/turbocheetah * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
------- Additional Comments From lmacken@redhat.com 2006-10-10 00:15 EST ------- http://people.redhat.com/lmacken/RPMS/python-turbocheetah-0.9.5-4.src.rpm http://people.redhat.com/lmacken/SPECS/python-turbocheetah.spec
* Tue Oct 10 2006 Luke Macken lmacken@redhat.com - 0.9.5-4 - Fix Source0 - Own %%{python_sitelib}/turbocheetah
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-10-10 11:03 EST ------- Looks good now.
APPROVED
I'll try to get to the other package ASAP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
lmacken@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From lmacken@redhat.com 2006-10-10 11:21 EST ------- Imported into CVS, added to owners.list, FC-5 branch requested, tagged and built for devel. Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-turbocheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: TurboCheetah|Review Request: python- |- TurboGears plugin to |turbocheetah - TurboGears |support use of Cheetah |plugin to support use of |templates |Cheetah templates
------- Additional Comments From kevin@tummy.com 2006-12-21 22:14 EST ------- Changing the summary for tracking purposes.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-turbocheetah - TurboGears plugin to support use of Cheetah templates
https://bugzilla.redhat.com/show_bug.cgi?id=206837
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org