Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947511
Tom "spot" Callaway <tcallawa(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tcallawa(a)redhat.com
Assignee|nobody(a)fedoraproject.org |tcallawa(a)redhat.com
Flags| |fedora-review+
--- Comment #4 from Tom "spot" Callaway <tcallawa(a)redhat.com> ---
= Review =
Good:
- rpmlint checks return:
glassfish-jax-rs-api.src: W: invalid-url Source0:
glassfish-jax-rs-api-2.0-src-git.tar.xz
Safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff okay, due to git source)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs, manual ok
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=c3lfUf8xCK&a=cc_unsubscribe