https://bugzilla.redhat.com/show_bug.cgi?id=1805738
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade(a)gmail.com
Assignee|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flags| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> ---
Review:
This package follows new fonts packaging guidelines.
Rpmlint
-------
Checking: ht-alegreya-sans-fonts-2.008-1.fc33.noarch.rpm
ht-alegreya-sans-fonts-2.008-1.fc33.src.rpm
ht-alegreya-sans-fonts.noarch: W: spelling-error %description -l en_US ludic ->
lucid, ludicrous
ht-alegreya-sans-fonts.noarch: W: spurious-executable-perm
/usr/share/doc/ht-alegreya-sans-fonts/OFL.txt
ht-alegreya-sans-fonts.noarch: E: wrong-script-end-of-line-encoding
/usr/share/doc/ht-alegreya-sans-fonts/OFL.txt
ht-alegreya-sans-fonts.src: W: spelling-error %description -l en_US ludic ->
lucid, ludicrous
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
Source checksums
----------------
https://github.com/huertatipografica/Alegreya-Sans/archive/v2.008/Alegrey...
:
CHECKSUM(SHA256) this package :
ea545572d49e18e675d6b72a6754da344e24b9cacc3d2b76c1eb2bf9ae73a402
CHECKSUM(SHA256) upstream package :
ea545572d49e18e675d6b72a6754da344e24b9cacc3d2b76c1eb2bf9ae73a402
Requires
--------
ht-alegreya-sans-fonts (rpmlib, GLIBC filtered):
config(ht-alegreya-sans-fonts)
fontpackages-filesystem
Provides
--------
ht-alegreya-sans-fonts:
config(ht-alegreya-sans-fonts)
font(alegreyasans)
font(alegreyasansblack)
font(alegreyasansextrabold)
font(alegreyasanslight)
font(alegreyasansmedium)
font(alegreyasansthin)
ht-alegreya-sans-fonts
metainfo()
metainfo(org.fedoraproject.ht-alegreya-sans-fonts.metainfo.xml)
All other things like license, config, metainfo files looks good.
Issues:
1) Fix the rpmlint warnings/errors before import of this package
2) I looked for %license in this package spec but cannot find it. Shouldn't we
need to mark some file say OFL.txt as %license?
I see in other packages when you create -doc subpackage %license gets marked
automatically.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component