https://bugzilla.redhat.com/show_bug.cgi?id=1244678

--- Comment #2 from Francesco Frassinelli fraph24@gmail.com --- (In reply to Eduardo Mayorga from comment #1)

Now you must use the %license macro to include the license text instead of %docs. See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ LicensingGuidelines#License_Text

Fixed, thank you.

Spec URL: https://about.frafra.eu/duperemove.spec SRPM URL: https://about.frafra.eu/duperemove-0.09.5-2.fc22.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

--- Comment #3 from Eduardo Mayorga e@mayorgalinux.com --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues: ======= - Bundled libraries: list.h; provided by kernel-devel rbtree.c, rbtree.h; provided by kcbench-data - Correct license is GPLv2. GPLv2+ corresponds to bundled rbtree* files. - Package must not own /usr/share/man/man8. Suggestion: %{_mandir}/man8/*.8* - install commands in Makefile do not preserve timestamps with the -p parameter. - CFLAGS and LDFLAGS not set.

===== MUST items =====

C/Cou++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [!]: Package does not own files or directories owned by other packages. Note: This package is owning /usr/share/man/man8(filesystem). [!]: %build honors applicable compiler flags or justifies otherwise. Note: CFLAGS and LDFLAGS not set. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [!]: Package complies to the Packaging Guidelines See Issues above. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. Note: install commands in Makefile do not preserve timestamps with the -p parameter. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: duperemove-0.09.5-2.fc24.x86_64.rpm duperemove-0.09.5-2.fc24.src.rpm duperemove.x86_64: W: spelling-error Summary(en_US) deduping -> deducing, deducting duperemove.x86_64: W: spelling-error %description -l en_US deduplication -> reduplication, duplication, quadruplication duperemove.x86_64: W: spelling-error %description -l en_US btrfs -> barfs duperemove.x86_64: W: invalid-url URL: https://github.com/markfasheh/duperemove <urlopen error ('_ssl.c:574: The handshake operation timed out',)> duperemove.x86_64: E: standard-dir-owned-by-package /usr/share/man/man8 duperemove.src: W: spelling-error Summary(en_US) deduping -> deducing, deducting duperemove.src: W: spelling-error %description -l en_US deduplication -> reduplication, duplication, quadruplication duperemove.src: W: spelling-error %description -l en_US btrfs -> barfs duperemove.src: W: invalid-url URL: https://github.com/markfasheh/duperemove <urlopen error [Errno -5] No address associated with hostname> duperemove.src:39: W: macro-in-%changelog %license 2 packages and 0 specfiles checked; 1 errors, 9 warnings.

Rpmlint (debuginfo) ------------------- Checking: duperemove-debuginfo-0.09.5-2.fc24.x86_64.rpm duperemove-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/duperemove-0.09.5/rbtree.c duperemove-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/duperemove-0.09.5/rbtree.h 1 packages and 0 specfiles checked; 2 errors, 0 warnings.

Rpmlint (installed packages) ---------------------------- duperemove-debuginfo.x86_64: W: invalid-url URL: https://github.com/markfasheh/duperemove <urlopen error [Errno -5] No address associated with hostname> duperemove-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/duperemove-0.09.5/rbtree.h duperemove-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/duperemove-0.09.5/rbtree.c duperemove.x86_64: W: invalid-url URL: https://github.com/markfasheh/duperemove <urlopen error [Errno -5] No address associated with hostname> duperemove.x86_64: E: standard-dir-owned-by-package /usr/share/man/man8 2 packages and 0 specfiles checked; 3 errors, 2 warnings.

Requires -------- duperemove (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libgcrypt.so.20()(64bit) libgcrypt.so.20(GCRYPT_1.6)(64bit) libglib-2.0.so.0()(64bit) libgpg-error.so.0()(64bit) libgthread-2.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH)

Provides -------- duperemove: duperemove duperemove(x86-64)

Source checksums ---------------- https://github.com/markfasheh/duperemove/archive/v0.09.5.tar.gz#/duperemove-... : CHECKSUM(SHA384) this package : fdd7f79f1bc368e89bd60eb0382a07b2d86a47ecee3604c79172fe5d9235041feb1d0d2f96ed0588c9933d7f909954f5 CHECKSUM(SHA384) upstream package : fdd7f79f1bc368e89bd60eb0382a07b2d86a47ecee3604c79172fe5d9235041feb1d0d2f96ed0588c9933d7f909954f5

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

James Hogarth james.hogarth@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |james.hogarth@gmail.com

--- Comment #5 from James Hogarth james.hogarth@gmail.com --- I'd say libbloom and libxxhash realistically should be packaged separately and then this blocked against those...

Note that btrfs-progs-devel includes rbtree.h ... you might try building against that (though I've not had a chance to check the exposed functions yet) ...

It might be better to have pkgconfig(glib-2.0) and pkgconfig(sqlite3) in the BR instead of naming the packages specifically.

Rather than naming SBINDIR and MANDIR specifically you can just pass PREFIX=%{_prefix} in to the %make_install

Especially given how few files there are (only 8 including the man pages) I'd specifically list them rather than doing general globs of %{_mandir} and %{_sbindir} to avoid accidents in capturing too much during packaging.

Note that there is a csum-test which can be used to check the algorithm is being used correctly ... adding a %check to the spec file with something akin to this appears to work building against an F23 mock of the git master:

%check dd if=/dev/urandom of=4kfilerand count=1 bs=4096 tgt_hash="$(sha256sum ./4kfilerand)" [[ "$(./csum-test -b 1024 --hash=sha256 ./4kfilerand | grep 4kfilerand)" == "${tgt_hash}" ]] [[ "$(./csum-test -b 4096 --hash=sha256 ./4kfilerand | grep 4kfilerand)" == "${tgt_hash}" ]]

Note there are dedup patches being proposed for 4.5 on the btrfs mailing list at the moment so it's not actually clear if this particular tool has a future anyway if btrfs-progs gets an actual dedup subcommand...

I've sent a mail into the list to get clarification on this.

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

Francesco Frassinelli (frafra) fraph24@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fraph24@gmail.com | |) |

--- Comment #7 from Francesco Frassinelli (frafra) fraph24@gmail.com --- (In reply to James Hogarth from comment #6)

Francesco are you still interested in packing this

Sure I am! I'm waiting for https://bugzilla.redhat.com/show_bug.cgi?id=1282063

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

--- Comment #9 from Francesco Frassinelli (frafra) fraph24@gmail.com --- (In reply to James Hogarth from comment #8)

I've marked it as blocking to make it clear :)

Thank you :)

Do you have the other library in review to block as well?

No, I'm sorry.

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

Francesco Frassinelli (frafra) fraph24@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fraph24@gmail.com | |) |

--- Comment #11 from Francesco Frassinelli (frafra) fraph24@gmail.com --- Hi James, I tried to include rbtree.h and list.h from btrfs-progs-devel, with no success (warnings and errors). I think it would be quicker to let you do the job, because I am not sure how to proceed (I think we should use kernel-devel as building dependency, but I don't know how to include the sources correctly) :)

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

Eric Sandeen esandeen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |esandeen@redhat.com

--- Comment #13 from Eric Sandeen esandeen@redhat.com --- XFS has removed the "experimental" tag from reflink, so for filesystems created with the reflink feature, duperemove can now be used on XFS as well. So I'd really like to see this move forward; anything I can do to help?

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

Jonathan Dieter jdieter@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jdieter@gmail.com

--- Comment #15 from Jonathan Dieter jdieter@gmail.com --- Not sure if anyone is still interested in packaging this, but I have updated packages that unbundle xxhash.

https://www.jdieter.net/downloads/duperemove.spec https://www.jdieter.net/downloads/duperemove-0.11-1.fc28.src.rpm

If Francesco isn't interested, but someone is interested in reviewing, I would be happy to take this.

https://bugzilla.redhat.com/show_bug.cgi?id=1244678

Francesco Frassinelli (frafra) fraph24@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fraph24@gmail.com | |) |

--- Comment #17 from Francesco Frassinelli (frafra) fraph24@gmail.com --- (In reply to Jonathan Dieter from comment #16)

This review appears to be stalled. Francesco, if you're still interested in packaging this, I'd be happy to help, but, if not, I would like to take it over. Please respond one way or another within a week.

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Sorry for the late reply, I just moved to another country and I am pretty busy. Feel free to continue the process.