Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-SQL-Shell - Command interpreter for DBI shells Alias: perl-SQL-Shell
https://bugzilla.redhat.com/show_bug.cgi?id=504524
Summary: Review Request: perl-SQL-Shell - Command interpreter for DBI shells Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/SQL-Shell OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/perl-SQL-Shell.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-SQL-Shell-1.14-1.fc10.src.rpm
Description: SQL::Shell is a command-interpreter API for building shells and batch scripts. A command-line interface with readline support is included as part of the CPAN distribution. See SQL::Shell::Manual for a user guide. SQL::Shell offers features similar to the mysql or sql*plus client programs but is database independent.
This package provides the backend SQL::Shell libraries. For the command-line interperter (sqlsh), please also install the sqlsh package.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1397935
*rt-0.10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504524
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-06-08 00:24:55 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1397935 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a313e85c6e22eda8d8df1fdb835e5437ddab6225 SQL-Shell-1.14.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=31, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.35 cusr 0.04 csys = 0.42 CPU) + Package perl-SQL-Shell-1.14-1.fc12.noarch => Provides: perl(SQL::Shell) = 1.14 perl(SQL::Shell::Manual) = 1.6 perl(Tie::Rowset::InMemory) Requires: perl(Carp) perl(DBI) perl(File::Path) perl(IO::File) perl(URI::Escape) perl(constant) perl(strict) perl(vars) + Not a GUI application
Should 1) Add following for subpackage sqlsh %defattr(-,root,root,-)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504524
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2009-06-08 00:43:23 EDT --- New Package CVS Request ======================= Package Name: perl-SQL-Shell Short Description: Command interpreter for DBI shells Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504524
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504524
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2009-06-08 12:27:58 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504524
--- Comment #4 from Chris Weyl cweyl@alumni.drew.edu 2009-06-08 20:27:16 EDT --- (In reply to comment #1)
Should
- Add following for subpackage sqlsh
%defattr(-,root,root,-)
Done. Thanks! :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504524
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #5 from Chris Weyl cweyl@alumni.drew.edu 2009-06-08 21:44:37 EDT --- Thanks for the review! :-)
package-review@lists.fedoraproject.org