https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Bug ID: 1414004 Summary: Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: valtri@civ.zcu.cz QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rs... SRPM URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rs... Description: Mark specs pending or skipped for specific Ruby engine (e.g. MRI or JRuby) / version combinations. Fedora Account System Username: valtri
COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500704/
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1414001, 1414002
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1414001 [Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant https://bugzilla.redhat.com/show_bug.cgi?id=1414002 [Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1414001, 1414002 | Depends On| |1414001, 1414002
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1414001 [Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant https://bugzilla.redhat.com/show_bug.cgi?id=1414002 [Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414004 Bug 1414004 depends on bug 1414001, which changed state.
Bug 1414001 Summary: Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant https://bugzilla.redhat.com/show_bug.cgi?id=1414001
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1414004 Bug 1414004 depends on bug 1414002, which changed state.
Bug 1414002 Summary: Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant https://bugzilla.redhat.com/show_bug.cgi?id=1414002
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review?
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- If you are still interested in this, first please upgrade to 0.1.4. Anyway taking.
By the way, I would appreciate it if you would review my review request (bug 1446927)
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
--- Comment #2 from František Dvořák valtri@civ.zcu.cz --- Spec URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.5-1/rubygem-rs... SRPM URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.5-1/rubygem-rs...
The new version.
I'll take the review, thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Mamoru TASAKA mtasaka@fedoraproject.org --- One note:
* Possibly unneeded files - Please check if the files under bin/ is really needed. Looks like these are scripts used for development or for installation process, and don't seem to be needed for runtime (and actually these don't seem useful)
Otherwise okay. - spec file clean - rpmlint clean - license okay (MIT) - builds fine (F-27, F-26) - installation okay - basic functionality okay
------------------------------------------------ This package (rubygem-rspec-pending_for) is APPROVED by mtasaka ------------------------------------------------
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
--- Comment #4 from František Dvořák valtri@civ.zcu.cz --- You're right, binaries in %{gem_instdir}/bin/ can be excluded. Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-rspec-pending_for
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- rubygem-rspec-pending_for-0.1.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-34c4e4709d
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rubygem-rspec-pending_for-0.1.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-169fc72a5d
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-rspec-pending_for-0.1.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-34c4e4709d
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-rspec-pending_for-0.1.5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-169fc72a5d
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-05-08 10:20:53
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- rubygem-rspec-pending_for-0.1.5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1414004
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- rubygem-rspec-pending_for-0.1.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org