https://bugzilla.redhat.com/show_bug.cgi?id=1352380
Bug ID: 1352380 Summary: Review Request: python-parsimonious - a lookahead parser written in pure Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: codyfh@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://107.170.38.8/python-parsimonious.spec SRPM URL: http://107.170.38.8/python-parsimonious-0.6.2-1.fc23.src.rpm Description:
Hello! I just finished making this package, it's my first one so if there are mistakes please let me know.
Parsimonious aims to be the fastest arbitrary-lookahead parser written in pure Python—and the most usable. It's based on parsing expression grammars (PEGs), which means you feed it a simplified sort of EBNF notation. Parsimonious was designed to undergird a MediaWiki parser that wouldn't take 5 seconds or a GB of RAM to do one page, but it's applicable to all sorts of languages.
Fedora Account System Username: thornycrackers
https://bugzilla.redhat.com/show_bug.cgi?id=1352380
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@redhat.com Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1352380
Eduardo Mayorga e@mayorgalinux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |e@mayorgalinux.com Assignee|nobody@fedoraproject.org |e@mayorgalinux.com Flags| |fedora-review?
--- Comment #1 from Eduardo Mayorga e@mayorgalinux.com --- Taking the review. I'll take care of the sponsoring process.
- rpmlint's output is not clean: python-parsimonious.noarch: W: incoherent-version-in-changelog 0.6.2 ['0.6.2-1.fc25', '0.6.2-1'] See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
- The package must provide python2-parsimonious. Since there will be Python 3 support in the near future, it's best to create python2-parsimonious and python3-parsimonious subpackages. See: https://fedoraproject.org/wiki/Packaging:Python#Provides See: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
- I do not understand the point of the conditional. You don't use the value of with_python3 in any place in the Spec.
Please address these issues and I'll review it again.
package-review@lists.fedoraproject.org