Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Bug ID: 891999 Summary: Review Request: lua-penlight - Penlight Lua Libraries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: thomas.moschny@gmx.de
Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-1.a.fc17.src.rpm
Description: Penlight brings together a set of generally useful pure Lua modules, focussing on input data handling (such as reading configuration files), functional programming (such as map, reduce, placeholder expressions,etc), and OS path management. Much of the functionality is inspired by the Python standard libraries.
Fedora Account System Username: thm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Thomas Moschny thomas.moschny@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |891996 (lua-ldoc) Alias| |lua-penlight Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Thomas Moschny thomas.moschny@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
--- Comment #1 from Thomas Moschny thomas.moschny@gmx.de --- Reset the fedora-review flag, somehow I misread the guidelines.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #2 from Stanislav Ochotnicky sochotni@redhat.com --- I will not post whole output of fedora-review since it's unnecessary, the package is mostly good. Three points remain:
1. Have you tried running tests from "tests" directory? 2. It would be nice to package examples as a separate subpackage too.
3. There are also two typos, one discovered by rpmlint: lua-penlight.noarch: W: spelling-error %description -l en_US focussing -> focusing, focus sing, focus-sing 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
and another in comment: # there's a circlular (build) dependency with lua-ldoc ^
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sochotni@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |sochotni@redhat.com
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #3 from Thomas Moschny thomas.moschny@gmx.de --- Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-2.a.fc17.src.rpm
%changelog * Wed Jan 9 2013 Thomas Moschny <..> - 1.0.3-2.a - Fix typos. - Package examples as a separate subpackage. - Run tests.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #4 from Stanislav Ochotnicky sochotni@redhat.com --- Package now fails to build (during tests): lua: run.lua:3: module 'lfs' not found
Seems like tests should only be enabled when docs are built as well
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #5 from Thomas Moschny thomas.moschny@gmx.de --- Sorry, forgot one BR.
Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-3.a.fc17.src.rpm
%changelog * Thu Jan 10 2013 Thomas Moschny <..> - 1.0.3-3.a - Add BR on lua-filesystem (needed when running the tests). - Fix line-endings for the examples.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Stanislav Ochotnicky sochotni@redhat.com --- Very nice, thanks for taking the issues up with upstream as well.
APPROVED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Thomas Moschny thomas.moschny@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Thomas Moschny thomas.moschny@gmx.de --- Thanks again for the review!
New Package SCM Request ======================= Package Name: lua-penlight Short Description: Penlight Lua Libraries Owners: thm Branches: f16 f17 f18 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- lua-penlight-1.0.3-3.a.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- lua-penlight-1.0.3-3.a.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc16
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- lua-penlight-1.0.3-3.a.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/lua-penlight-1.0.3-3.a.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- lua-penlight-1.0.3-3.a.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-22 20:44:33
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- lua-penlight-1.0.3-3.a.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- lua-penlight-1.0.3-3.a.fc16 has been pushed to the Fedora 16 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- lua-penlight-1.0.3-3.a.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org