https://bugzilla.redhat.com/show_bug.cgi?id=1583798
Rex Dieter <rdieter(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #8 from Rex Dieter <rdieter(a)gmail.com> ---
Thanks looks good, approved.
Minor things to consider in the future,
1. avoid using globs like:
desktop-file-validate %{buildroot}%{_datadir}/applications/*.desktop
appstream-util validate-relax --nonet
%{buildroot}%{_datadir}/metainfo/*.appdata.xml
and
%{_datadir}/applications/*.desktop
%{_datadir}/metainfo/*.appdata.xml
and reference the full files precisely (without globs). These should generally
never change, and if they do, you should be mindful of that.
2. consider using
%{_metainfodir}/...
instead of hard-coded
%{_datadir}/metainfo/...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component