Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Bug ID: 886230 Summary: Review Request: php-phpass - Portable password hashing framework for use in PHP applications Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: gregor@freenet.de
Spec URL: http://brummbq.fedorapeople.org/php-phpass.spec SRPM URL: http://brummbq.fedorapeople.org/php-phpass-0.3-1.fc17.src.rpm Description: phpass (pronounced "pH pass") is a portable public domain password hashing framework for use in PHP applications. It is meant to work with PHP 3 and above.
The preferred (most secure) hashing method supported by phpass is the OpenBSD-style Blowfish-based bcrypt and known in PHP as CRYPT_BLOWFISH, with a fallback to BSDI-style extended DES-based hashes, known in PHP as CRYPT_EXT_DES, and a last resort fallback to MD5-based salted and variable iteration count password hashes implemented in phpass itself (also referred to as portable hashes). Fedora Account System Username: brummbq
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Gregor Tätzner gregor@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |858841 (owncloud)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- I don't understand the cp -a %{SOURCE0} README.devel
Why do you want to provide the source tarball as a readme file ?
Please run the provided test
BuildRequires: php-cli
%check php test.php | grep PASSED
I don't really agree on the need of a devel sub-package. Simply add the test.php file and c directory to the %doc of the main package. (not a blocker, packager choice)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #2 from Gregor Tätzner gregor@freenet.de --- Spec URL: http://brummbq.fedorapeople.org/php-phpass.spec SRPM URL: http://brummbq.fedorapeople.org/php-phpass-0.3-2.fc17.src.rpm
(In reply to comment #1)
I don't understand the cp -a %{SOURCE0} README.devel
Why do you want to provide the source tarball as a readme file ?
You can't understand that, because it's utter nonsense: I forgot to list the README file in SOURCES and used the first source as README erroneously :)
Please run the provided test
BuildRequires: php-cli
%check php test.php | grep PASSED
I don't really agree on the need of a devel sub-package. Simply add the test.php file and c directory to the %doc of the main package. (not a blocker, packager choice)
agreed, there are just a few files anyway.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Joseph Marrero jmarrero@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jmarrero@gmail.com Assignee|nobody@fedoraproject.org |jmarrero@gmail.com Flags| |fedora-review+
--- Comment #3 from Joseph Marrero jmarrero@gmail.com --- rpmlint output:
php-phpass.src: W: spelling-error %description -l en_US bcrypt -> crypt, b crypt 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -------------------- NO real errors found with rpm lint Macros OK Licence OK
Installs OK
No blockers.
APPROVED.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Gregor Tätzner gregor@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Gregor Tätzner gregor@freenet.de --- New Package SCM Request ======================= Package Name: php-phpass Short Description: Portable password hashing framework for use in PHP applications Owners: brummbq Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- php-phpass-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- php-phpass-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-phpass-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-phpass-0.3-2.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-phpass-0.3-2.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-19 22:11:29
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-phpass-0.3-2.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-phpass-0.3-2.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886230
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-phpass-0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org