https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Bug ID: 2257189 Summary: Review Request: rust-reference-counted-singleton - Reference-counted singleton whose protected data can be recreated as needed Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton.spec SRPM URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton-0.1.2-1.fc...
Description: Reference-counted singleton whose protected data can be recreated as needed.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2257190
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2257190 [Bug 2257190] Review Request: rust-selinux - Flexible Mandatory Access Control for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Three minor issues:
- Please document the patch (like adding a line above "Patch: ..." with "# bump serial_test dev-dependency from 0.5 to 2" - Can you submit the patch to update this dependency as a PR to upstream? - Please exclude some files that don't make sense in the packaging - like coverage.sh and coverage-style.css.patch. This might also make sense as a PR for upstream.
Other than that, package looks good.
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #2 from Michel Lind michel@michel-slm.name --- (In reply to Fabio Valentini from comment #1)
Three minor issues:
- Please document the patch (like adding a line above "Patch: ..." with "#
bump serial_test dev-dependency from 0.5 to 2"
it has this right now # * bump serial_test to 2
I can make it more explicit
- Can you submit the patch to update this dependency as a PR to upstream?
Can do. In this case I should probably make upstream accept a range from 0.5 to 2, right, since obviously it still works with 0.5 too
- Please exclude some files that don't make sense in the packaging - like
coverage.sh and coverage-style.css.patch. This might also make sense as a PR for upstream.
Will do too, thanks
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- (In reply to Michel Lind from comment #2)
(In reply to Fabio Valentini from comment #1)
Three minor issues:
- Please document the patch (like adding a line above "Patch: ..." with "#
bump serial_test dev-dependency from 0.5 to 2"
it has this right now # * bump serial_test to 2
I can make it more explicit
Ah, that line is only in the linked spec, but not in the spec in the linked SRPM. So I guess you forgot to re-run rpmbuild -bs after adding it. The line you have there is fine, no need to be more verbose.
- Can you submit the patch to update this dependency as a PR to upstream?
Can do. In this case I should probably make upstream accept a range from 0.5 to 2, right, since obviously it still works with 0.5 too
That would be perfect. Something like ">=0.5,<3".
- Please exclude some files that don't make sense in the packaging - like
coverage.sh and coverage-style.css.patch. This might also make sense as a PR for upstream.
Will do too, thanks
:+1:
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #4 from Michel Lind michel@michel-slm.name --- (In reply to Fabio Valentini from comment #3)
(In reply to Michel Lind from comment #2)
(In reply to Fabio Valentini from comment #1)
Three minor issues:
- Please document the patch (like adding a line above "Patch: ..." with "#
bump serial_test dev-dependency from 0.5 to 2"
it has this right now # * bump serial_test to 2
I can make it more explicit
Ah, that line is only in the linked spec, but not in the spec in the linked SRPM. So I guess you forgot to re-run rpmbuild -bs after adding it. The line you have there is fine, no need to be more verbose.
- Can you submit the patch to update this dependency as a PR to upstream?
Can do. In this case I should probably make upstream accept a range from 0.5 to 2, right, since obviously it still works with 0.5 too
That would be perfect. Something like ">=0.5,<3".
- Please exclude some files that don't make sense in the packaging - like
coverage.sh and coverage-style.css.patch. This might also make sense as a PR for upstream.
Will do too, thanks
:+1:
sent PRs upstream for both (see updated spec for links to PRs)
Spec URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton.spec SRPM URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton-0.1.2-1.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/re | |ference-counted-singleton Keywords| |AutomationTriaged
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6872357 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
You would not have needed to exclude ".gitignore", any hidden files should already be excluded by %cargo_install automatically, but it doesn't hurt.
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #7 from Michel Lind michel@michel-slm.name --- Ah, I'll keep it for now since it doesn't matter anyway, and upstream will hopefully accept the PR soon with or without changes. thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-reference-counted-singleton
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-cb524aedca has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-cb524aedca
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3be808720f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3be808720f
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-cb524aedca has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-cb524aedca *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-cb524aedca
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3be808720f has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3be808720f *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3be808720f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2024-01-12 18:47:27
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3be808720f has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2257189
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-cb524aedca has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org