https://bugzilla.redhat.com/show_bug.cgi?id=1448694
Mamoru TASAKA <mtasaka(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
One recommendation
* I usually recommend to place "README.md" to main package, as it says
"README", however this is up to your decision.
* license okay
* source matches the upstream
* spec file clean
* koji build okay (F-27, F-26)
* rpmlint clean
* installation okay
* basic functionality (taken from README.md) works.
$ ruby -e 'require "json-schema" ; schema =
{"type"=>"object",
"required"=>["a"],
"properties"=>{"a"=>{"type"=>"integer"}}}
; p
JSON::Validator.validate(schema, { "a" => 5 }) ; p
JSON::Validator.validate(schema, { "a" => 4.3 })'
true
false
=====================================================
This package (rubygem-json-schema) is APPROVED
by mtasaka
=====================================================
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component