https://bugzilla.redhat.com/show_bug.cgi?id=1348932
Didik Supriadi <didiksupriadi41(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |didiksupriadi41(a)gmail.com
--- Comment #16 from Didik Supriadi <didiksupriadi41(a)gmail.com> ---
License: BSD-2-Clause
This is true but it must be filled with its short name.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...
See
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses
Invalid URL.
To correctly reference the source, See
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
%post
# enable bash-git-prompt
cat << EOF >> /etc/bashrc
%{START_TOKEN}
if [ -f %{_datadir}/%{name}/gitprompt.sh ]; then
# Set config variables first
GIT_PROMPT_ONLY_IN_REPO=1
GIT_PROMPT_THEME=Default
source %{_datadir}/%{name}/gitprompt.sh
fi
%{END_TOKEN}
EOF
%postun
# remove bash-git-prompt setup
sed -i -e '/^%{START_TOKEN}/, /^%{END_TOKEN}/{d}' /etc/bashrc
You should not edit the file that you don't own.
files
%defattr(-,root,root,-)
This is not needed anymore.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions
install -pm 644 README.md %{buildroot}%{_datadir}/%{name}
README already in %doc, right?
* Sat Mar 31 2018 Koustubh Sinkar <ksinkar(a)gmail.com>
- Making the spec file more standards compliant
- support for new lines
* Tue Jun 28 2016 Koustubh Sinkar <ksinkar(a)gmail.com>
- Updating the spec file to reflect more recent changes
You should write the version in changelog.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component