Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: opencpn - An open source chart plotter/navigator
https://bugzilla.redhat.com/show_bug.cgi?id=612224
Summary: Review Request: opencpn - An open source chart plotter/navigator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jolsa@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://people.redhat.com/jolsa/opencpn/opencpn.spec SRPM URL: http://people.redhat.com/jolsa/opencpn/opencpn-2.1.624a-1.fc13.src.rpm
Description: OpenCPN is a free software (GPL) project to create a concise chart plotter and navigation software for use as an underway or planning tool. OpenCPN is developed by a team of active sailors using real world conditions for program testing and refinement.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612224
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dan@danny.cz AssignedTo|nobody@fedoraproject.org |dan@danny.cz Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612224
--- Comment #1 from Dan Horák dan@danny.cz 2010-07-10 09:04:46 EDT --- some issues discovered before doing a formal review: - use the standard macro for calling cmake - https://fedoraproject.org/wiki/Packaging:Cmake - explicit Requires are not needed, they will be filled in automatically by rpmbuild - the %{_datadir}/opencpn directory is not owned by the package, either add %dir %{_datadir}/opencpn or use only %{_datadir}/opencpn as it will include all subdirs into the package - doesn't build in rawhide, I think the path for gdk-pixbuf2 includes is not set, probably related to the recent move of gdk-pixbuf2 to its own package - builds its own copy of bzip2 library, you must add BR: bzip2-devel - includes (outdated) zlib headers, I would rather remove them before build to be sure they are not used - I would prefer to see each BR: on its own line, it's easier to track their changes - includes GDAL library (or parts only?) - a system copy must be used - you probably want to add BR: gpsd-devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612224
Jean-Eudes ONFRAY sethdart@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sethdart@yahoo.com
--- Comment #2 from Jean-Eudes ONFRAY sethdart@yahoo.com 2010-10-07 10:18:23 EDT --- FYI rawhide failure to build is related to a bug in cmake. See https://bugzilla.redhat.com/show_bug.cgi?id=639058
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=612224
--- Comment #3 from Jean-Eudes ONFRAY je@onfray.fr 2012-02-18 19:07:47 EST --- Hi,
I'd like to followup on this to see OpenCPN packaged in Fedora. If possible, I'd like to co-maintain this package. I'm part of the upstream team and already providing Fedora rpm there.
Here's updated spec & srpm for latest 2.5.0 http://je.onfray.fr/dl/opencpn.spec http://je.onfray.fr/dl/opencpn-2.5.0-1.fc16.src.rpm
As you'll see, I added a rule to remove embedded bzip2 & zlib to ensure they are not used. I wanted to do the same for tinyxml but they're including tinystr.h that's not provided in Fedora (unnecessary include: it's only required if tinyxml is built without stl) This would require a patch to include/gpxdocument.h Please tell me if I should do it. I'll open a bug upstream to have it removed from future release.
gdal library has lots of changes from upstream. Changes heavily related to internal use. Would probably not fit to upstream for inclusion.
nmea0183 does not exist as a lib. There are two different versions: one for core OpenCPN, one for the dashboard plugin. Both are different. It's required by lead OpenCPN dev to ensure plugins doesn't rely on any special version from core.
Please comment.
Regards, Jean-Eudes
package-review@lists.fedoraproject.org