Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690519
--- Comment #2 from Jussi Lehtola <jussi.lehtola(a)iki.fi> 2011-03-24 11:33:23 EDT
---
rpmlint output:
snappy.src: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
snappy.src: W: invalid-url Source0:
http://snappy.googlecode.com/files/snappy-1.0.0.tar.gz HTTP Error 404: Not
Found
snappy.x86_64: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
snappy-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 4 warnings.
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
NEEDSWORK
- License is specified as ASL 2.0 in most of the source code files.
- However, some files do not mention a license at all, just the copyright.
- The included COPYING contains a BSD license.
=> License tag should read ASL 2.0 and BSD just to be on the safe side.
Please ask upstream to clarify the licensing.
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
9d83bdcf0c79a8de608fa969c2909204 snappy-1.0.0.tar.gz
9d83bdcf0c79a8de608fa969c2909204 ../SOURCES/snappy-1.0.0.tar.gz
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
- Although IMHO using
CXXFLAGS="%{optflags} -DNDEBUG"
would be better.
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Add COPYING to %doc.
- Please remove empty %doc line from -devel.
MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. OK
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
The following don't matter if you're not targeting older versions of EPEL.
EPEL: Clean section exists. NEEDSWORK
EPEL: Buildroot cleaned before install. NEEDSWORK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.