https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Bug ID: 1336872 Summary: Review Request: php-symfony-securiy-acl - Symfony Security Component - ACL (Access Control List) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: shawn@iwin.ski QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/1cbf8802ef711a295f621a836bc8...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony-securiy-acl-2.8.0-1.fc24...
Description: Symfony Security Component - ACL (Access Control List)
Fedora Account System Username: siwinski
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Please fix obvious typo (rpmlnt: E: invalid-spec-name)
%global github_name security-acl %global composer_project securiy-acl
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 1158772 --> https://bugzilla.redhat.com/attachment.cgi?id=1158772&action=edit phpci.log
phpCompatInfo version 5.0.0 DB version 1.8.1 built May 03 2016 07:41:55 CEST
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
--- Comment #3 from Shawn Iwinski shawn@iwin.ski --- Wow :/
Fixed. I did not bump the release since the generated RPMs are a different name. Diff: https://github.com/siwinski/rpms/commit/a0c2bcbed1541f46c9d9308b32def2c198af...
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/a0c2bcbed1541f46c9d9308b32de...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony-security-acl-2.8.0-1.fc2...
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
--- Comment #4 from Remi Collet fedora@famillecollet.com --- Created attachment 1159980 --> https://bugzilla.redhat.com/attachment.cgi?id=1159980&action=edit review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1336872 Buildroot used: fedora-rawhide-x86_64
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines
=> OK, package design for symfony 2.8
[x]: Package does not own files or directories owned by other packages. => Ok (as dropped from synfony 2.8)
[~]: Requires correct, justified where necessary. Instead of Requires: php-composer(symfony/security-core) >= %{symfony_min_ver} Conflicts: php-symfony-security < 2.8.0 Could be simpler to (keep 2.7 for the BR) Requires: php-composer(symfony/security-core) >= 2.8
[x]: Latest version is packaged. => in the 2.8 branch
[x]: %check is present and all tests pass. PHP 5: ok PHP 7: ok
No Blocker, so the package conform with Fedora Guidelines.
=== APPROVED ===
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
--- Comment #6 from Shawn Iwinski shawn@iwin.ski --- THANKS for the review! SCM request opened via pkgdb.
(In reply to Remi Collet from comment #5)
[~]: Requires correct, justified where necessary. Instead of Requires: php-composer(symfony/security-core) >= %{symfony_min_ver} Conflicts: php-symfony-security < 2.8.0 Could be simpler to (keep 2.7 for the BR) Requires: php-composer(symfony/security-core) >= 2.8
I did not sub-package the individual components of the security module (they are all just php-symfony-security with multiple provides) so this would overwrite the 2.7 security-acl files. Is that OK?
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-securiy-acl
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |php-symfony-securiy-acl - |php-symfony-security-acl - |Symfony Security Component |Symfony Security Component |- ACL (Access Control List) |- ACL (Access Control List)
--- Comment #8 from Shawn Iwinski shawn@iwin.ski --- (In reply to Jon Ciesla from comment #7)
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-securiy-acl
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |php-symfony-security-acl
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limburgher@gmail.com Flags| |needinfo?(limburgher@gmail. | |com)
--- Comment #9 from Shawn Iwinski shawn@iwin.ski --- (In reply to Jon Ciesla from comment #7)
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-securiy-acl
Hey Jon -- I had a typo in the package name :( Would it be easier to: 1) ask to rename created pkg "php-symfony-securiy-acl" to "php-symfony-security-acl" 2) submit a new pkg request and then request that the old one be deleted?
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(limburgher@gmail. | |com) |
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Submit a new SCM request for the correct name and EOL the old one.
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-symfony-security-acl
https://bugzilla.redhat.com/show_bug.cgi?id=1336872
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-05-28 22:06:56
package-review@lists.fedoraproject.org