https://bugzilla.redhat.com/show_bug.cgi?id=2294380
Bug ID: 2294380 Summary: Review Request: openjpeg - C-Library for JPEG 2000 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: manisandro@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://smani.fedorapeople.org/review/openjpeg.spec SRPM URL: https://smani.fedorapeople.org/review/openjpeg-2.5.2-2.fc41.src.rpm Description: C-Library for JPEG 2000 Fedora Account System Username: smani
Scratch build: C-Library for JPEG 2000
This is a re-review to rename the package from openjpeg2 to openjpeg.
https://bugzilla.redhat.com/show_bug.cgi?id=2294380
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/uclouvai | |n/openjpeg
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7671029 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- mingw32-openjpeg : /usr/i686-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/openjpeg.h mingw32-openjpeg : /usr/i686-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/opj_config.h mingw64-openjpeg : /usr/x86_64-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/openjpeg.h mingw64-openjpeg : /usr/x86_64-w64-mingw32/sys-root/mingw/include/openjpeg-2.5/opj_config.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/openjpeg Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti... - Package has .a files: mingw32-openjpeg, mingw64-openjpeg. Illegal package name: mingw32-openjpeg, mingw64-openjpeg. Does not provide -static: mingw32-openjpeg, mingw64-openjpeg. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-... - Documentation size is 13807907 bytes in 521 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2294380
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |sergio@serjux.com Flags| |fedora-review? CC| |sergio@serjux.com
https://bugzilla.redhat.com/show_bug.cgi?id=2294380
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|NEW |ASSIGNED
--- Comment #2 from Sergio Basto sergio@serjux.com --- (In reply to Fedora Review Service from comment #1)
- Documentation size is 13807907 bytes in 521 files. Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
the spec is almost equal to openjpeg2 , without all renames to avoid avoid conflicts with openjpeg-1.x , which is good .
I just find documentation in devel-docs package which is correct . Maybe I call this sub-package as doc only, instead devel-doc but is not important, neither I'm sure that is the correct.
Package APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2294380
--- Comment #3 from Sandro Mani manisandro@gmail.com --- Thanks, unretirement of openjpeg requested at https://pagure.io/releng/issue/12179
https://bugzilla.redhat.com/show_bug.cgi?id=2294380
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |trawets@amazon.com Flags| |needinfo?(trawets@amazon.co | |m)
--- Comment #4 from Sandro Mani manisandro@gmail.com --- Since I acutally don't maintain the native openjpeg, I guess the proper way forward is for @trawets@amazon.com or @rdieter@fedoraproject.org to update the package with this spec, resp add me as package admin if they're happy with me taking over.
package-review@lists.fedoraproject.org