https://bugzilla.redhat.com/show_bug.cgi?id=1966392
Bug ID: 1966392 Summary: Review Request: rust-libdeflate-sys - Bindings to libdeflate for DEFLATE (de)compression Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: remilauzier@protonmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/f... SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/f... Description: Bindings to libdeflate for DEFLATE (de)compression exposed as non-streaming buffer operations. Contains bindings for raw deflate, zlib, and gzip data. Fedora Account System Username: remilauzier
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
--- Comment #1 from Rémi Lauzier remilauzier@protonmail.com --- https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/f... https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/f... I include the link to the bug demanding that the license file should be include in the crate source.
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - It would be nice to unbundle and package libdeflate, although it doesn't seem trivial.
- The bundled libdeflate is MIT licensed
# Upstream license specification: Apache-2.0 ³ libdeflate: MIT License: ASL 2.0 and MIT
- And you need to add the license file to %license:
%files devel %doc README.md %license LICENSE libdeflate/COPYING %{cargo_registry}/%{crate}-%{version_no_tilde}/
- You need to add a bundled Provides
Provides: bundled(libdeflate) = 1.7-1.20201124git4a0bb73
- Simplify the summary:
rust-libdeflate-sys-devel.noarch: E: summary-too-long C Bindings to libdeflate for DEFLATE (de)compression exposed as non-streaming buffer operations
- License ok - Latest version packaged - Builds in mock
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
--- Comment #3 from Rémi Lauzier remilauzier@protonmail.com --- Done.
https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/f... https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/f...
Unbundling libdeflate is above my skill for now.
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libdeflate-sys
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-eafd94e9a0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-eafd94e9a0
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-eafd94e9a0 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-eafd94e9a0 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-eafd94e9a0
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1966392
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-06-16 20:48:05
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-eafd94e9a0 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org