Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Bug ID: 886261 Summary: Review Request: php-when - Date/Calendar recursion library for PHP 5.2+ Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: gregor@freenet.de
Spec URL: http://brummbq.fedorapeople.org/php-when.spec SRPM URL: http://brummbq.fedorapeople.org/php-when-0.3-1.fc17.src.rpm Description: PHP library that handles recursive dates: It determines the next date of recursion given an iCalendar "rrule" like pattern. Fedora Account System Username: brummbq
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Gregor Tätzner gregor@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |858841 (owncloud)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- As the Test suite is provided, you should run it during %check.
For now, test suite isn't compatible with latest PHPUnit (use some deprecated include).
so, for example, in %prep, remove this include, and fix the other include path
sed -e '/Framework.php/d' \ -e '/When.php/s:./:when/:' \ -e '/When_Iterator.php/s:./:when/:' \ -i Tests/*php
and in %check cd Tests phpunit -d include_path=%{buildroot}%{_datadir}/php:.:%{_datadir}/php:%{_datadir}/pear .
Please don't install tests in /usr/share/php, which is part of the default include_path. Better solution is to use /usr/share/tests/when
You need to own the /usr/share/tests directory (or require pear which own it)
Please consider removing "5.2+" from summary, PHP is enough.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #2 from Gregor Tätzner gregor@freenet.de --- Created attachment 663920 --> https://bugzilla.redhat.com/attachment.cgi?id=663920&action=edit test execution
Does the test work for you? There are a lot of errors and some failures.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Try adding "-d date.timezone=UTC" to phpunit command
Yes test works for me (local build). Of course, you probably need more BR to enable it during mock/koji build.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #4 from Gregor Tätzner gregor@freenet.de --- Spec URL: http://brummbq.fedorapeople.org/php-when.spec SRPM URL: http://brummbq.fedorapeople.org/php-when-0.3-2.fc17.src.rpm
(In reply to comment #3)
Try adding "-d date.timezone=UTC" to phpunit command
Yes test works for me (local build). Of course, you probably need more BR to enable it during mock/koji build.
thanks, that did the trick. It works also in mock
(In reply to comment #1)
Better solution is to use /usr/share/tests/when
check
You need to own the /usr/share/tests directory (or require pear which own it)
yum whatprovides /usr/share/tests php-Pimple-1.0.0-2.fc17.noarch : A simple Dependency Injection Container for PHP php-lessphp-0.3.8-3.fc17.noarch : A compiler for LESS written in PHP
no sign of pear? However, I'm owning /usr/share/tests now as well.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Created attachment 663994 --> https://bugzilla.redhat.com/attachment.cgi?id=663994&action=edit phpci.log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Created attachment 663995 --> https://bugzilla.redhat.com/attachment.cgi?id=663995&action=edit php-when-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 886261
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #7 from Remi Collet fedora@famillecollet.com --- See the few comments in the attached review report.
No Blocker, so
=== APPROVED ===
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Gregor Tätzner gregor@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Gregor Tätzner gregor@freenet.de --- New Package SCM Request ======================= Package Name: php-when Short Description: Date/Calendar recursion library for PHP Owners: brummbq Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.iwinski@gmail.com
--- Comment #10 from Shawn Iwinski shawn.iwinski@gmail.com --- For the tests, wouldn't it be better to use "%{_datadir}/tests/%{name}" so it would be less likely for a directory name collision?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-when-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-when-0.3-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-when-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-when-0.3-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-when-0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-when-0.3-2.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-when-0.3-2.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-19 22:10:10
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-when-0.3-2.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-when-0.3-2.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886261
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-when-0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org