https://bugzilla.redhat.com/show_bug.cgi?id=1755870
Bug ID: 1755870 Summary: Review Request: perl-Test-Deep-Fuzzy - Fuzzy number comparison with Test::Deep Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: yaneti@declera.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://declera.com/~yaneti/perl-Test-Deep-Fuzzy/perl-Test-Deep-Fuzzy.spec SRPM URL: http://declera.com/~yaneti/perl-Test-Deep-Fuzzy/perl-Test-Deep-Fuzzy-0.01-1.... Description: Test::Deep::Fuzzy provides fuzzy number comparison with Test::Deep.
Fedora Account System Username: yaneti
https://bugzilla.redhat.com/show_bug.cgi?id=1755870
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1755870
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 addresses are Ok.
TODO: There is no link from a page on the URL location to Source0. Maybe you should use Source0 from Github releases, or change URL to CPAN to be consistent.
Source0 archive (SHA-256: f5c94fdd836b0d07187e297556986b0888d2cd5d136251962eed427580394daf) is original. Ok. Summary verified from lib/Test/Deep/Fuzzy.pm. Ok. Description verified from lib/Test/Deep/Fuzzy.pm. Ok. License verified from lib/Test/Deep/Fuzzy.pm, README.md, and LICENSE. Ok. No XS code, noarch BuildArch is Ok.
TODO: Do not version perl-interpreter (perl-interpreter >= 5.008001). Use 'perl(:VERSION) >= 5.8.1' for that purpose. perl-interpreter has an epoch number and the comparison does not work.
FIX: Do not build-require 'perl(Module::Build)'. It's not used anywhere.
All tests pass. Ok.
$ rpmlint perl-Test-Deep-Fuzzy.spec ../SRPMS/perl-Test-Deep-Fuzzy-0.01-1.fc32.src.rpm ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-1.fc32.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-1.fc32.noarch.rpm drwxr-xr-x 2 root root 0 Sep 27 17:12 /usr/share/doc/perl-Test-Deep-Fuzzy -rw-r--r-- 1 root root 104 Nov 8 2016 /usr/share/doc/perl-Test-Deep-Fuzzy/Changes -rw-r--r-- 1 root root 1252 Nov 8 2016 /usr/share/doc/perl-Test-Deep-Fuzzy/README.md drwxr-xr-x 2 root root 0 Sep 27 17:12 /usr/share/licenses/perl-Test-Deep-Fuzzy -rw-r--r-- 1 root root 18400 Nov 8 2016 /usr/share/licenses/perl-Test-Deep-Fuzzy/LICENSE -rw-r--r-- 1 root root 2233 Sep 27 17:12 /usr/share/man/man3/Test::Deep::Fuzzy.3pm.gz -rw-r--r-- 1 root root 20 Sep 27 17:12 /usr/share/man/man3/Test::Deep::Fuzzy::Number.3pm.gz drwxr-xr-x 2 root root 0 Sep 27 17:12 /usr/share/perl5/vendor_perl/Test drwxr-xr-x 2 root root 0 Sep 27 17:12 /usr/share/perl5/vendor_perl/Test/Deep drwxr-xr-x 2 root root 0 Sep 27 17:12 /usr/share/perl5/vendor_perl/Test/Deep/Fuzzy -rw-r--r-- 1 root root 1142 Nov 8 2016 /usr/share/perl5/vendor_perl/Test/Deep/Fuzzy.pm -rw-r--r-- 1 root root 1292 Nov 8 2016 /usr/share/perl5/vendor_perl/Test/Deep/Fuzzy/Number.pm File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-1.fc32.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(Exporter) >= 5.57 1 perl(Math::Round) 1 perl(Scalar::Util) 1 perl(Test::Deep::Cmp) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Run-require 'perl(B)' (lib/Test/Deep/Fuzzy/Number.pm:7). FIX: Run-require 'perl(strict)' (lib/Test/Deep/Fuzzy.pm:3). FIX: Run-require 'perl(warnings)' (lib/Test/Deep/Fuzzy.pm:4). TODO: Alternatively build-require 'perl-generators' instead of listing the Requires manually.
$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-1.fc32.noarch.rpm | sort -f | uniq -c 1 perl-Test-Deep-Fuzzy = 0.01-1.fc32 FIX: Provide 'perl(Test::Deep::Fuzzy) = 0.01' (lib/Test/Deep/Fuzzy.pm:1). FIX: Provide 'perl(Test::Deep::Fuzzy::Number)' (lib/Test/Deep/Fuzzy/Number.pm:1). TODO: Alternatively build-require 'perl-generators' instead of listing the Provides manually.
The package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=37893689). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all 'FIX' items, consider correcting 'TODO' items, and provide a new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1755870
--- Comment #2 from Yanko Kaneti yaneti@declera.com --- Thanks for the review. I believe I've followed all your suggestions in -2
Spec URL: http://declera.com/~yaneti/perl-Test-Deep-Fuzzy/perl-Test-Deep-Fuzzy.spec SRPM URL: http://declera.com/~yaneti/perl-Test-Deep-Fuzzy/perl-Test-Deep-Fuzzy-0.01-2....
https://bugzilla.redhat.com/show_bug.cgi?id=1755870
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppisar@redhat.com ---
TODO: There is no link from a page on the URL location to Source0. Maybe you should use Source0 from Github releases, or change URL to CPAN to be consistent.
-URL: https://github.com/karupanerura/Test-Deep-Fuzzy +URL: https://metacpan.org/pod/Test::Deep::Fuzzy We usually use a link to a CPAN release page https://metacpan.org/release/Test-Deep-Fuzzy. Not to a documentation of a module as you used. But this is distribution contain only one documented module so it does not matter much. Ok.
TODO: Do not version perl-interpreter (perl-interpreter >= 5.008001). Use 'perl(:VERSION) >= 5.8.1' for that purpose. perl-interpreter has an epoch number and the comparison does not work.
-BuildRequires: perl-interpreter >= 5.008001 +BuildRequires: perl(:VERSION) >= 5.8.1 FIX: Build-require 'perl-interpreter' (perl-Test-Deep-Fuzzy.spec:33).
FIX: Do not build-require 'perl(Module::Build)'. It's not used anywhere.
-BuildRequires: perl(Module::Build) Ok.
$ rpmlint perl-Test-Deep-Fuzzy.spec ../SRPMS/perl-Test-Deep-Fuzzy-0.01-2.fc32.src.rpm ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(:VERSION) >= 5.8.1 1 perl(B) 1 perl(Exporter) >= 5.57 1 perl(Math::Round) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Test::Deep::Cmp) 1 perl(Test::Deep::Fuzzy::Number) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm | sort -f | uniq -c 1 perl(Test::Deep::Fuzzy) = 0.01 1 perl(Test::Deep::Fuzzy::Number) 1 perl-Test-Deep-Fuzzy = 0.01-2.fc32 Binary provides are Ok.
$ resolvedeps f32-build ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm Binary dependencies are resolvable. Ok.
Please correct the 'FIX' item before building this package. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1755870
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Deep-Fuzzy
https://bugzilla.redhat.com/show_bug.cgi?id=1755870
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-09-30 15:17:58
--- Comment #5 from Yanko Kaneti yaneti@declera.com --- Thanks. Fixed the spec some more after import. Built in rawhide
As to why have this package https://bugzilla.redhat.com/show_bug.cgi?id=1757117
package-review@lists.fedoraproject.org