https://bugzilla.redhat.com/show_bug.cgi?id=1826270
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Link ID| |Github
| |atoomic/B-COW/issues/1
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
The standalone spec file seems to be newer. I will use that for the review.
Url and Source0 addresses are usable. Ok.
A Source0 archive (SHA-256:
9c7de86542871bc0ac8e6b4f7363bba4f6c5cc07e06fadc51d3a78832fcfca89) is original.
Ok.
Summary verifed from lib/B/COW.pm. Ok.
Description verified from lib/B/COW.pm. Ok.
License verified from lib/B/COW.pm, Makefile.PL, LICENSE, COW.xs, and README.
Ok.
TODO: Use %{make_build} and %{make_install} macros.
All tests pass. Ok.
$ rpmlint perl-B-COW.spec ../SRPMS/perl-B-COW-0.003-2.fc33.src.rpm
../RPMS/x86_64/perl-B-COW-*
sh: /usr/bin/python2: No such file or directory
perl-B-COW.src: W: spelling-error %description -l en_US naïve -> nave, naive
perl-B-COW.x86_64: W: spelling-error %description -l en_US naïve -> nave, naive
perl-B-COW.x86_64: E: library-not-linked-against-libc
/usr/lib64/perl5/vendor_perl/auto/B/COW/COW.so
4 packages and 1 specfiles checked; 1 errors, 2 warnings.
rpmlint is Ok.
The link error is because of a weak __cxa_finalize symbol. Weak symbols do not
need to be fulfilled.
$ rpm -q -lv -p ../RPMS/x86_64/perl-B-COW-0.003-2.fc33.x86_64.rpm
drwxr-xr-x 2 root root 0 Apr 21 13:40
/usr/lib/.build-id
drwxr-xr-x 2 root root 0 Apr 21 13:40
/usr/lib/.build-id/c9
lrwxrwxrwx 1 root root 57 Apr 21 13:40
/usr/lib/.build-id/c9/5e1f2c8a5362612b167e996167a8bab86a0327 ->
../../../../usr/lib64/perl5/vendor_perl/auto/B/COW/COW.so
drwxr-xr-x 2 root root 0 Apr 21 13:40
/usr/lib64/perl5/vendor_perl/B
-rw-r--r-- 1 root root 3150 Apr 20 17:59
/usr/lib64/perl5/vendor_perl/B/COW.pm
drwxr-xr-x 2 root root 0 Apr 21 13:40
/usr/lib64/perl5/vendor_perl/auto/B
drwxr-xr-x 2 root root 0 Apr 21 13:40
/usr/lib64/perl5/vendor_perl/auto/B/COW
-rwxr-xr-x 1 root root 15768 Apr 21 13:40
/usr/lib64/perl5/vendor_perl/auto/B/COW/COW.so
drwxr-xr-x 2 root root 0 Apr 21 13:40
/usr/share/doc/perl-B-COW
-rw-r--r-- 1 root root 336 Apr 20 17:59
/usr/share/doc/perl-B-COW/Changes
-rw-r--r-- 1 root root 371 Apr 20 17:59
/usr/share/doc/perl-B-COW/README
drwxr-xr-x 2 root root 0 Apr 20 17:59
/usr/share/doc/perl-B-COW/examples
-rw-r--r-- 1 root root 805 Apr 20 17:59
/usr/share/doc/perl-B-COW/examples/synopsis.pl
drwxr-xr-x 2 root root 0 Apr 21 13:40
/usr/share/licenses/perl-B-COW
-rw-r--r-- 1 root root 18340 Apr 20 17:59
/usr/share/licenses/perl-B-COW/LICENSE
-rw-r--r-- 1 root root 2246 Apr 21 13:40
/usr/share/man/man3/B::COW.3pm.gz
A file layout and the permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/perl-B-COW-0.003-2.fc33.x86_64.rpm | sort
-f | uniq -c
1 libperl.so.5.30()(64bit)
1 libpthread.so.0()(64bit)
1 libpthread.so.0(GLIBC_2.2.5)(64bit)
1 perl(:MODULE_COMPAT_5.30.2)
1 perl(base)
1 perl(Exporter)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/x86_64/perl-B-COW-0.003-2.fc33.x86_64.rpm | sort
-f | uniq -c
1 perl(B::COW) = 0.003
1 perl-B-COW = 0.003-2.fc33
1 perl-B-COW(x86-64) = 0.003-2.fc33
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/x86_64/perl-B-COW-0.003-2.fc33.x86_64.rpm
Binary dependencies are resolvable. Ok.
FATAL: The package does not build in Fedora 33
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=43596524) on big-endian
machines (
https://github.com/atoomic/B-COW/issues/1).
Otherwise the package is in-line with Fedora and Perl packaging guidelines.
Resolution: NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component