Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: schedtool - A tool to query or alter process scheduling policy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248857
------- Additional Comments From adel.gadllah(a)gmail.com 2007-07-22 05:29 EST -------
(In reply to comment #11)
Blocker:
* Please s!%{_prefix}/bin/!%{_bindir}/! in %files section
ok fixed that one.
Some other notes; please think about them and fix where you agree
with them:
* the summary starts with "A " -- the rule of tumb iirc is to go without it
(e.g. Summary: Tool to foo)
ok, fixed
* The description starts in lower case; rule of tumb iirc is to start
capitalized
ok changed.
* Please tell upstream that
> Copyright (C) 19yy <name of author>
> Gnomovision version 69, Copyright (C) 19yy name of author
in LICENSE looks bogus ;-)
ok mail sent.
* is there a specific reasons why you excluded TODO? I'd say it
should be
shipped -- it's small and doesn't do any harm for those not intersted in it
ok shipped now.
* that DESTPREFIX stuff looks intersting, but well, it seems to be
needed...
I already contacted upstream (and sent a patch) and they will fix it in the next
version.
* might be better to not let the Makefile gzip the man page as rpm
does this on
its own (in case rpm starts to use bz2 or whatever in the long term)
this would require patching the makefile... is this really needed?
can add a patch to do it if its prefferd that way.
Will approve the package and sponser you if you fix the blocker and
comment on
the other stuff.
ok, thx
here is the new spec and srpm:
http://tgmweb.at/gadllah/schedtool.spec
http://tgmweb.at/gadllah/schedtool-1.2.10-2.fc7.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.