https://bugzilla.redhat.com/show_bug.cgi?id=987457
Bug ID: 987457 Summary: Review Request: rubygem-fast_xs - Provides C extensions for escaping text Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: msuchy@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://miroslav.suchy.cz/fedora/rubygem-fast_xs/rubygem-fast_xs.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-fast_xs/rubygem-fast_xs-0.8.0-2.fc19... Description: fast_xs provides C extensions for escaping text. The original String#fast_xs method is based on the xchar code by Sam Ruby: * http://intertwingly.net/stories/2005/09/28/xchar.rb * http://intertwingly.net/blog/2005/09/28/XML-Cleansing _why also packages an older version with Hpricot (patches submitted). The version here should be compatible with the latest version of Hpricot code. Ruby on Rails will automatically use String#fast_xs from either Hpricot or this gem version with the bundled Builder package. String#fast_xs is an almost exact translation of Sam Ruby's original implementation (String#to_xs), but it does escape """ (which is an optional, but all parsers are able ot handle it. XML::Builder as packaged in Rails 2.0 will be automatically use String#fast_xs instead of String#to_xs available.
Fedora Account System Username: msuchy
https://bugzilla.redhat.com/show_bug.cgi?id=987457
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jstribny@redhat.com Assignee|nobody@fedoraproject.org |jstribny@redhat.com Flags| |fedora-review?
--- Comment #1 from Josef Stribny jstribny@redhat.com --- I will take it for a review.
https://bugzilla.redhat.com/show_bug.cgi?id=987457
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+
--- Comment #2 from Josef Stribny jstribny@redhat.com --- Please fix:
* Escape macros in comments rubygem-fast_xs.spec:57: W: macro-in-comment %gem_dir
* Description of -doc package should end up with a dot and the description of the main package could a little more formatted (2 line breaks after a paragraph).
Otherwise the spec looks good, it builds, installs & works. Since the issues are minor and could be fixed before pushing I am APPROVING this package.
https://bugzilla.redhat.com/show_bug.cgi?id=987457
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Miroslav Suchý msuchy@redhat.com --- New Package SCM Request ======================= Package Name: rubygem-fast_xs Short Description: Provides C extensions for escaping text Owners: msuchy Branches: f19 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=987457
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=987457
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=987457
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=987457
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- rubygem-fast_xs-0.8.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-fast_xs-0.8.0-3.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=987457
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- rubygem-fast_xs-0.8.0-3.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=987457
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |rubygem-fast_xs-0.8.0-3.fc1 | |9 Resolution|--- |ERRATA Last Closed| |2013-08-19 17:29:07
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rubygem-fast_xs-0.8.0-3.fc19 has been pushed to the Fedora 19 stable repository.
package-review@lists.fedoraproject.org