https://bugzilla.redhat.com/show_bug.cgi?id=1379393
Rex Dieter <rdieter(a)math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter <rdieter(a)math.unl.edu> ---
naming: ok
license: ok
1. could/should leave out:
BuildRequires: %{?fedora:cmake}%{!?fedora:cmake3} >= 3.0
that dependency should be handled by whatever package that provides the
%{cmake_lxqt}
macro
macros: ok
2. should consider adjusting pavucontrol-qt.desktop Name/GenericNameComment
somehow, it currently appears exactly the same as pavucontrol, so it's
hard/impossible to distinguish which is which, contains:
Name=PulseAudio Volume Control
GenericName=Volume Control
Comment=Adjust the volume level
(not a blocker, mostly a suggestion for pavucontrol-qt upstream)
scriptlets: ok (n/a)
sources: ok
32217c5ae8a846e92548a55b8d3b9267 pavucontrol-qt-0.1.0.tar.xz
otherwise, package is fairly simple and clean,
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component