https://bugzilla.redhat.com/show_bug.cgi?id=2268682
Bug ID: 2268682 Summary: Review Request: python-superqt - Missing widgets and components for PyQt/PySide Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: gui1ty@penguinpee.nl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gui1ty.fedorapeople.org/review/python-superqt.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-superqt-0.6.2-1.fc41.src.rpm
Description:
This package aims to provide high-quality community-contributed Qt widgets and components for PyQt & PySide that are not provided in the native QtWidgets module.
Components are tested on:
- macOS, Windows, & Linux - Python 3.8 and above - PyQt5 (5.11 and above) & PyQt6 - PySide2 (5.11 and above) & PySide6
Fedora Account System Username: gui1ty
Copr build: https://copr.fedorainfracloud.org/coprs/gui1ty/Spyder6/build/7129503/
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2268677 Blocks| |2106899 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2106899 [Bug 2106899] spyder-6.0.0a4 is available https://bugzilla.redhat.com/show_bug.cgi?id=2268677 [Bug 2268677] Review Request: python-pytest-qt - pytest support for PyQt and PySide applications
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7129674 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 | |(fedora-neuro,NeuroFedora)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2268679, 2268680
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2268679 [Bug 2268679] Review Request: python-cmap - Scientific colormaps for python, without dependencies https://bugzilla.redhat.com/show_bug.cgi?id=2268680 [Bug 2268680] Review Request: python-pyconify - Iconify for Python - universal icon framework
https://bugzilla.redhat.com/show_bug.cgi?id=2268682 Bug 2268682 depends on bug 2268680, which changed state.
Bug 2268680 Summary: Review Request: python-pyconify - Iconify for Python - universal icon framework https://bugzilla.redhat.com/show_bug.cgi?id=2268680
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2268682 Bug 2268682 depends on bug 2268679, which changed state.
Bug 2268679 Summary: Review Request: python-cmap - Scientific colormaps for python, without dependencies https://bugzilla.redhat.com/show_bug.cgi?id=2268679
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2268682 Bug 2268682 depends on bug 2268677, which changed state.
Bug 2268677 Summary: Review Request: python-pytest-qt - pytest support for PyQt and PySide applications https://bugzilla.redhat.com/show_bug.cgi?id=2268677
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |ASSIGNED CC| |jamatos@fc.up.pt
--- Comment #2 from José Matos jamatos@fc.up.pt --- The package is approved.
Fix the license issue on import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues: ======= - Dist tag is present. - There are two files with MIT License superqt-0.6.2/examples/throttler_demo.py superqt-0.6.2/src/superqt/utils/_throttler.py
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.12/site-packages, /usr/lib/python3.12 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2504 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-superqt , python3-superqt+pyqt6 [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: python3-superqt-0.6.2-1.fc41.noarch.rpm python3-superqt+pyqt6-0.6.2-1.fc41.noarch.rpm python-superqt-0.6.2-1.fc41.src.rpm ========================================================================================================== rpmlint session starts ========================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6okhshvq')] checks: 32, packages: 3
python-superqt.src: E: spelling-error ('macOS', '%description -l en_US macOS -> ma Cos, mac OS, mac-OS') python3-superqt+pyqt6.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-superqt+pyqt6.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-superqt.noarch: E: spelling-error ('macOS', '%description -l en_US macOS -> ma Cos, mac OS, mac-OS') python3-superqt+pyqt6.noarch: W: no-documentation ==================================================================== 3 packages and 0 specfiles checked; 4 errors, 1 warnings, 26 filtered, 4 badness; has taken 0.8 s =====================================================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
python3-superqt.noarch: E: spelling-error ('macOS', '%description -l en_US macOS -> ma Cos, mac OS, mac-OS') python3-superqt+pyqt6.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-superqt+pyqt6.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-superqt+pyqt6.noarch: W: no-documentation 2 packages and 0 specfiles checked; 3 errors, 1 warnings, 22 filtered, 3 badness; has taken 0.3 s
Source checksums ---------------- https://github.com/pyapp-kit/superqt/archive/v0.6.2/superqt-0.6.2.tar.gz : CHECKSUM(SHA256) this package : 97aea462722bbd23e31abad42eaf82ea35236554066672dd8904b3a5a8d8fb8b CHECKSUM(SHA256) upstream package : 97aea462722bbd23e31abad42eaf82ea35236554066672dd8904b3a5a8d8fb8b
Requires -------- python3-superqt (rpmlib, GLIBC filtered): ((python3.12dist(typing-extensions) < 3.10 or python3.12dist(typing-extensions) > 3.10) with python3.12dist(typing-extensions) >= 3.7.4.3) python(abi) python3.12dist(pygments) python3.12dist(qtpy)
python3-superqt+pyqt6 (rpmlib, GLIBC filtered): python(abi) python3-superqt python3.12dist(pyqt6)
Provides -------- python3-superqt: python-superqt python3-superqt python3.12-superqt python3.12dist(superqt) python3dist(superqt)
python3-superqt+pyqt6: python-superqt+pyqt6 python3-superqt+pyqt6 python3.12-superqt+pyqt6 python3.12dist(superqt[pyqt6]) python3dist(superqt[pyqt6])
Diff spec file in url and in SRPM --------------------------------- --- /home/jamatos/tmp/fedora/2268682-python-superqt/srpm/python-superqt.spec 2024-03-19 20:09:36.472495861 +0000 +++ /home/jamatos/tmp/fedora/2268682-python-superqt/srpm-unpacked/python-superqt.spec 2024-03-09 00:00:00.000000000 +0000 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global pypi_name superqt %global forgeurl https://github.com/pyapp-kit/superqt @@ -80,3 +90,6 @@
%changelog -%autochangelog +## START: Generated by rpmautospec +* Sat Mar 09 2024 Sandro devel@penguinpee.nl - 0.6.2-1 +- Initial package +## END: Generated by rpmautospec
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2268682 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: C/C++, PHP, Java, Haskell, Ocaml, Perl, fonts, R, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
--- Comment #3 from Sandro gui1ty@penguinpee.nl --- Thank you for all the reviews!
(In reply to José Matos from comment #2)
Issues:
- Dist tag is present.
- There are two files with MIT License
superqt-0.6.2/examples/throttler_demo.py superqt-0.6.2/src/superqt/utils/_throttler.py
I'll fix the license on import. I overlooked the license for `_throttler.py`. The other file is not shipped.
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-superqt
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4342ae8f71 (python-superqt-0.6.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4342ae8f71
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-03-20 20:08:19
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4342ae8f71 (python-superqt-0.6.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c552c1b9fd has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c552c1b9fd *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2268682
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org