Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Bug ID: 889476 Summary: Review Request: kio-mtp - An MTP KIO slave for KDE Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: jgrulich@redhat.com
Spec URL: http://jgrulich.fedorapeople.org/kio-mtp.spec SRPM URL: http://jgrulich.fedorapeople.org/kio-mtp-0.70-1.20121221gitccaa6d1.fc17.src.... Description: Provides KIO Access to MTP devices. This KIO slave is necessary if you want access to MTP devices through application like Dolphin. Fedora Account System Username: jgrulich
Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4810276
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997 (kde-reviews)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #1 from Jan Grulich jgrulich@redhat.com --- *** Bug 889474 has been marked as a duplicate of this bug. ***
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Dan Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dvratil@redhat.com
--- Comment #2 from Dan Vrátil dvratil@redhat.com --- You don't have to run remove buildroot in %clean and you should ask upstream to include LICENSE file. Otherwise it looks good.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Dan Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |dvratil@redhat.com
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tigcc.ticalc.org Alias| |kio-mtp
--- Comment #3 from Kevin Kofler kevin@tigcc.ticalc.org --- So, as we've been discussing on IRC recently, I think this should be called kio_mtp rather than kio-mtp, but I'm not sure my opinion is the consensus.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #4 from Kevin Kofler kevin@tigcc.ticalc.org --- (See also the kio-upnp-ms review.)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #5 from Jan Grulich jgrulich@redhat.com --- Updated =======
Spec URL: http://jgrulich.fedorapeople.org/kio_mtp.spec SRPM URL: http://jgrulich.fedorapeople.org/kio_mtp-0.70-2.20121225gitfae62fc.fc17.src....
* Thu Dec 25 2012 Jan Grulich jgrulich@redhat.com - 0.70-2.20121225gitfae62fc - Add LICENCE file - Remove %clean - Change name
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Dan Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #6 from Jan Grulich jgrulich@redhat.com --- New Package SCM Request ======================= Package Name: kio_mtp Short Description: MTP KIO slave for KDE Owners: jgrulich Branches: f17 f18 InitialCC: rdieter dvratil
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: kio-mtp - |Review Request: kio_mtp - |An MTP KIO slave for KDE |An MTP KIO slave for KDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #7 from Kevin Fenzi kevin@scrye.com --- A few items:
1. Please include checkout info for the source per: http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
2. Package review guidelines list as a MUST adding the rpmlint output to the review. :)
kio_mtp.src: E: invalid-spec-name
(your spec in src.rpm still has the - instead of the _)
kio_mtp.src:49: W: macro-in-%changelog %clean
Should use %% :)
kio_mtp.src: E: specfile-error warning: bogus date in %changelog: Thu Dec 25 2012 Jan Grulich jgrulich@redhat.com - 0.70-2.20121225gitfae62fc
Tue?
kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) kio -> oik, kip, kilo kio_mtp-debuginfo.i686: W: spelling-error Summary(en_US) mtp -> mt, mp, map kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US kio -> oik, kip, kilo kio_mtp-debuginfo.i686: W: spelling-error %description -l en_US mtp -> mt, mp, map kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) kio -> oik, kip, kilo kio_mtp-debuginfo.x86_64: W: spelling-error Summary(en_US) mtp -> mt, mp, map kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US kio -> oik, kip, kilo kio_mtp-debuginfo.x86_64: W: spelling-error %description -l en_US mtp -> mt, mp, map 5 packages and 0 specfiles checked; 2 errors, 9 warnings.
Can all be ignored. ;)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #8 from Kevin Fenzi kevin@scrye.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kio_mtp-0.70-2.20121225gitfae62fc.fc...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-13 23:08:44
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- kio_mtp-0.70-2.20121225gitfae62fc.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889476
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- kio_mtp-0.70-2.20121225gitfae62fc.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org