Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=510104
--- Comment #5 from Jussi Lehtola <jussi.lehtola(a)iki.fi> 2009-07-10 04:31:09 EDT
---
(In reply to comment #4)
spec file is a mess use macros instead of hard coded path.
http://www.fedoraproject.org/wiki/Packaging:RPMMacros
/usr/share/epic5/script/ should be %{_datadir}/%{name}/script
Package must own all directories it creates.
http://www.fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOw...
use %dir %{_datadir}/%{name} and %dir %{_datadir}/%{name}/script
Shorten list by using %{_datadir}/%{name}/script/*
Yes, it seems to be rather a mess. %{_datadir}/epic5/ should be owned too, so
the files section would end up as
%{_bindir}/epic5
%{_bindir}/epic5-1.0
%{_datadir}/epic5/
%{_mandir}/man1/epic5.1.*
%{_libexecdir}/epic5-wserv4 <- add trailing slash if this is a directory
- The Requires
Requires: ncurses-devel >= 5.7-2
Requires: ruby-devel >= 1.8.6
Requires: perl-ExtUtils-Embed >= 1.28-69
should be BuildRequires. Also, you probably need perl-devel.
- Contact upstream so that they fix SMP make.
- The install command should be
make install IP=$RPM_BUILD_ROOT INSTALL_PROGRAM="install -c -p -m 755"
INSTALL_DATA="install -c -p -m 644"
to preserve time stamps (OK, not essential for the binaries). I have no idea
why make install compiles some test program, but it isn't installed so the
optflags are not needed in install.
- You could also ask upstream to change IP to the standard DESTDIR in the
makefile.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.