Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kde-filesystem - KDE filesystem layout
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248358
kevin(a)tigcc.ticalc.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From kevin(a)tigcc.ticalc.org 2007-07-16 22:58 EST -------
MUST Items:
! rpmlint output:
SRPM:
W: kde-filesystem no-url-tag
OK, makes sense for a package like
that.
W: kde-filesystem mixed-use-of-spaces-and-tabs (spaces: line 7, tab:
line 3)
OK, not a real issue, you may want to be consistent, but it doesn't
really
matter.
noarch RPM:
W: kde-filesystem no-documentation
OK, no documentation needed
for a package like that.
W: kde-filesystem hidden-file-or-dir /usr/share/applnk/.hidden
W: kde-filesystem hidden-file-or-dir /usr/share/applnk/.hidden
OK, this one is
really wanted.
E: kde-filesystem standard-dir-owned-by-package /usr/share/icons
! This one is already owned by filesystem, please omit.
W: kde-filesystem no-url-tag
OK, see above.
+ named and versioned according to the Package Naming Guidelines
+ spec file name matches base package name
+ Packaging Guidelines:
+ License Public Domain OK
+ No patent problems
+ No emulator, no firmware, no binary-only or prebuilt components
+ Complies with the FHS
+ proper changelog, tags, BuildRoot, Requires, BuildRequires, Summary,
Description
+ no non-UTF-8 characters
+ no relevant documentation which would need to be included
+ nothing to compile, so RPM_OPT_FLAGS, debuginfo, static libraries, .la
files, duplicated system libraries, rpaths, _smp_mflags don't apply
+ no configuration files, so %config guideline doesn't apply
+ no init scripts, so init script guideline doesn't apply
+ no executables, so no .desktop file present or needed
+ no timestamp-clobbering file commands
+ scriptlets are valid
+ not a web application, so web application guideline doesn't apply
+ no conflicts
+ complies with all the legal guidelines
+ no license which would need including (public domain)
+ spec file written in American English
+ spec file is legible
+ no source, so no need to check against upstream
+ builds on at least one arch (F7 i386 live system, FC6 i386 mock, Rawhide i386
mock)
+ no non-working arches, so no ExcludeArch needed
+ no build dependencies which would need listing as BuildRequires
+ locales handled properly (with %lang specifications)
+ no shared libraries, so need to call ldconfig
+ package not relocatable
! ownership correct (owns package-specific directories, doesn't own directories
owned by another package) except for %{_datadir}/icons as found by rpmlint
+ no duplicate files in %files
+ permissions set properly
+ %clean section present and correct
+ macros used where possible
+ no non-code content
+ no large documentation files, so no -doc package needed
+ no %doc files, so no possible issues with %doc files required at runtime
+ no header files or .so symlinks which would need a -devel package
+ no static libraries, so no -static package needed
+ no .pc files, so no Requires: pkgconfig needed
+ no .la files
+ no GUI programs (in fact, no executables at all), so no .desktop file needed
+ buildroot is deleted at the beginning of %install
But I strongly recommend a:
mkdir $RPM_BUILD_ROOT
after the:
rm -rf $RPM_BUILD_ROOT
to prevent a potential symlink attack as pointed out by the OpenSUSE folks.
+ all filenames are valid UTF-8
SHOULD Items:
+ no license which would need to be included
+ no translations for description and summary provided by upstream
+ builds in mock (tested FC6 i386 with Plague results and Rawhide i386, both on
F7 build host)
* skipping the "all architectures" test, I only have i386. There's nothing
potentially arch-specific in the package anyway
+ package only creates directories, so no functionality test needed
+ scriptlets are sane
+ no subpackages, so "Usually, subpackages other than devel should require the
base package using a fully versioned dependency." is irrelevant
+ no .pc files, so "placement of .pc files" is irrelevant
+ no file dependencies
Please remove:
%{_datadir}/icons/
from the file list as this is already owned by the filesystem package. With
this change, this is APPROVED.
I'd also suggest adding the mkdir $RPM_BUILD_ROOT, but this isn't a blocker.
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.