https://bugzilla.redhat.com/show_bug.cgi?id=1562643
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #5 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Own %{_pkgdocdir}
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/doc/python-slixmpp
Package otherwise approved. Fix the aforementioned issue before import.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "Unknown or generated", "MIT/X11 (BSD
like)", "MIT/X11
(BSD like) BSD (3 clause)", "BSD (3 clause)", "BSD
(unspecified)". 502
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/python-slixmpp/review-python-
slixmpp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/doc/python-slixmpp
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/doc/python-slixmpp
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-slixmpp
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-slixmpp-1.3.0-2.fc29.x86_64.rpm
python-slixmpp-doc-1.3.0-2.fc29.noarch.rpm
python-slixmpp-debugsource-1.3.0-2.fc29.x86_64.rpm
python-slixmpp-1.3.0-2.fc29.src.rpm
python-slixmpp-doc.noarch: W: spelling-error %description -l en_US reST ->
rest, re ST, re-ST
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/IoT_TestDevice.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/adhoc_provider.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/adhoc_user.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/admin_commands.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/confirm_answer.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/confirm_ask.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/custom_stanzas/custom_stanza_provider.py
/usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/custom_stanzas/custom_stanza_user.py
/usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/disco_browser.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/download_avatars.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/echo_client.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/echo_component.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/gtalk_custom_domain.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/http_over_xmpp.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/ibb_transfer/ibb_receiver.py
/usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/ibb_transfer/ibb_sender.py
/usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/mam.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/markup.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/migrate_roster.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/muc.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/ping.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/proxy_echo_client.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/pubsub_client.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/pubsub_events.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/register_account.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/roster_browser.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/rpc_async.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/rpc_client_side.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/rpc_server_side.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/s5b_transfer/s5b_receiver.py
/usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/s5b_transfer/s5b_sender.py
/usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/send_client.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/set_avatar.py /usr/bin/env python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/thirdparty_auth.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/user_location.py /usr/bin/env
python3
python-slixmpp-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/python-slixmpp-doc/examples/user_tune.py /usr/bin/env python3
python-slixmpp-debugsource.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 36 errors, 2 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component