https://bugzilla.redhat.com/show_bug.cgi?id=1896852
Bug ID: 1896852 Summary: Review Request: golang-github-facebook-ent - An entity framework for Go Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-facebook-ent/golang-g... SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-facebook-ent/golang-g...
Description:
Ent is a simple, yet powerful entity framework for Go, that makes it easy to build and maintain applications with large data-models.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |o.lemasle@gmail.com Assignee|nobody@fedoraproject.org |o.lemasle@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
--- Comment #2 from Olivier Lemasle o.lemasle@gmail.com --- Thank you Davide.
Please fix these rpmlint errors:
golang-github-facebook-ent-docs.x86_64: E: description-line-too-long C The package golang-github-facebook-ent-docs contains documentation and examples for golang-github-facebook-ent. golang-github-facebook-ent-docs.x86_64: E: version-control-internal-file /usr/share/doc/golang-github-facebook-ent-docs/doc/.gitignore golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/.gitignore golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/aggregate.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/code-gen.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/crud.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/dialects.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/getting-started.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/hooks.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/migrate.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/paging.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/predicates.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-annotations.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-def.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-edges.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-fields.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-indexes.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-mixin.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/transactions.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/traversals.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/README.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/core/Footer.js golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/pages/en/index.js golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/sidebars.json golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/static/css/custom.css golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/static/img/oss_logo.png
The golang-github-facebook-ent-docs can simply be split over multiple lines (should not exceed 79 characters/line). The .gitignore file should be removed, and the .md files should be chmod to remove execution permission.
Furtheremore, the golang-github-facebook-ent-devel package does not contain the examples, but does contain their README files: /usr/share/gocode/src/github.com/facebook/ent/examples/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/edgeindex/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/entcpkg/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/m2m2types/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/m2mbidi/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/m2mrecur/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2m2types/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2mrecur/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2o2types/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2obidi/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2orecur/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/privacyadmin/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/privacytenant/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/start/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/traversal/README.md
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
--- Comment #3 from Davide Cavalca dcavalca@fb.com --- Thanks! I think rpmlint should be good now, but I couldn't figure out how to exclude doc and examples from the -devel package. I can forcibly remove them in %prep, but then the packaging fails because %gopkgfiles still includes them in the file list. I also tried using the gosupfilesex and godocsex macros but they don't seem to be doing anything either.
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-facebook-ent/golang-g... SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-facebook-ent/golang-g...
Changelog: - Fix docs permissions and remove spurious gitignore
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Olivier Lemasle o.lemasle@gmail.com --- Package accepted.
- licence ok - spec ok - naming ok - rpmlint ok
I didn't find a way to remove the examples/*/README.md files either (actually, golist lists .md files even in ignored directories...), but this is not a problem.
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
--- Comment #5 from Davide Cavalca dcavalca@fb.com --- Thanks!
$ fedpkg request-repo golang-github-facebook-ent 1896852 https://pagure.io/releng/fedora-scm-requests/issue/30817
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-facebook-ent
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-03c8d62f77 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-03c8d62f77
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f8d23cd796 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8d23cd796
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-03c8d62f77 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-03c8d62f77 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-03c8d62f77
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f8d23cd796 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f8d23cd796 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8d23cd796
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-11-29 01:13:57
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f8d23cd796 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1896852
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-03c8d62f77 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org