Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: lookup - A graphical tool to search DNS for answers
https://bugzilla.redhat.com/show_bug.cgi?id=748017
Summary: Review Request: lookup - A graphical tool to search DNS for answers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: wjhns174@hardakers.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://www.hardakers.net/temp/lookup.spec SRPM URL: http://www.hardakers.net/temp/lookup-1.11-1.fc15.src.rpm Description: The lookup utility allows you to query the DNS for answers. It displays the results in a graphical tree structure, and checks the answers for validity and conformance with DNSSEC. The results are color coded based on their DNSSEC status.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #1 from Wes Hardaker wjhns174@hardakers.net 2011-10-21 15:48:57 EDT --- New copies to fix an include path problem:
Spec URL: http://www.hardakers.net/temp/lookup.spec SRPM URL: http://www.hardakers.net/temp/lookup-1.11-2.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
Paul Wouters paul@xelerance.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul@xelerance.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #2 from Wes Hardaker wjhns174@hardakers.net 2011-10-21 17:03:37 EDT --- Spec URL: http://www.hardakers.net/temp/lookup.spec SRPM URL: http://www.hardakers.net/temp/lookup-1.11-3.fc15.src.rpm
Removes the reference to the Requires: line that is auto-determined.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #3 from Wes Hardaker wjhns174@hardakers.net 2011-10-27 17:10:24 EDT --- http://www.hardakers.net/temp/lookup-1.11.p2-1.fc15.src.rpm http://www.hardakers.net/temp/lookup.spec
Updated to the upstream 1.11.p2 to add a man page and COPYING file and fix the .desktop file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #4 from Paul Wouters paul@xelerance.com 2011-10-27 19:20:32 EDT --- cd src/ && make -f Makefile install make[1]: Entering directory `/vol/home/paul/BUILD/lookup-1.11.p2/src' install -m 755 -p "build/lookup" "/home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/bin/lookup" install -m 644 -p /vol/home/paul/BUILD/lookup-1.11.p2/src/lookup.desktop /home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/share/applications/hildon/ install -m 644 -p /vol/home/paul/BUILD/lookup-1.11.p2/data/maemo/lookup.xpm /home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/share/pixmap/ install -m 644 -p /vol/home/paul/BUILD/lookup-1.11.p2/data/48x48/lookup.png /home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/share/icons/hicolor/48x48/apps/ install -m 755 -p build/lookup "build/"/usr/bin/lookup install: cannot create regular file `build//usr/bin/lookup': No such file or directory make[1]: [install] Error 1 (ignored)
That's for your upstream hat though, it seems to cause no issues for the package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #5 from Wes Hardaker wjhns174@hardakers.net 2011-10-28 00:08:03 EDT --- Huh, odd. Thanks. I'll go hunt that one down. It looks like an odd double install problem.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
Paul Wouters paul@xelerance.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |paul@xelerance.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #6 from Wes Hardaker wjhns174@hardakers.net 2011-10-28 16:33:18 EDT --- http://www.hardakers.net/temp/lookup-1.11.p2-2.fc15.src.rpm http://www.hardakers.net/temp/lookup.spec
These fix the double-install problem (with a broken DESTDIR for one)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
Paul Wouters paul@xelerance.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Paul Wouters paul@xelerance.com 2011-11-01 15:58:10 EDT ---
All issues fixed. PASS
note for upstream:
lookup.cpp: In member function 'void Lookup::createMenus()': lookup.cpp:233:14: warning: unused variable 'results' lookup.cpp:234:14: warning: unused variable 'submitResults' lookup.cpp: In member function 'void Lookup::init_libval()': lookup.cpp:263:42: warning: deprecated conversion from string constant to 'char*'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #8 from Paul Wouters paul@xelerance.com 2011-11-01 16:09:27 EDT --- Oops. forgot to include my checklist
[paul@bofh paul]$ rpmlint /home/paul/SRPMS/lookup-1.11.p2-2.fc14.src.rpm /home/paul/RPMS/x86_64/lookup-1.11.p2-2.fc14.x86_64.rpm /home/paul/RPMS/x86_64/lookup-debuginfo-1.11.p2-2.fc14.x86_64.rpm lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 2: warning: macro `UC' not defined lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 3: warning: macro `SH' not defined lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 10: warning: macro `PP' not defined lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 13: warning: macro `IP' not defined 3 packages and 0 specfiles checked; 0 errors, 4 warnings.
MUST: rpmlint OK MUST: package name OK MUST: The spec file name matches the base package MUST: The package meets the Packaging Guidelines . MUST: License BSD matches the source and fedora guidelines
MUST: LICENSE file included on %doc MUST: Americanized english used MUST: spec file legible MUST: source matches upstream MUST: compiles successfully MUST: mock rebuild confirmed build dependancies MUST: no locale's MUST: no libraries, no ldconfig needed MUST: does not bundle system libraries MUST: nor relocatable MUST: package owns its own dirs MUST: no duplicate files in %files MUST: consistently macro use MUST: The package contains code MUST: bi Large documentation files MUST: %doc does not affect runtime MUST: no Header files in base MUST: no Static libraries in base MUST: OK no libraries MUST: no devel pacakge MUST: no .la or .a files MUST: Packages include proper %{name}.desktop file, and is installed properly with desktop-file-install in the %install section. MUST: Packages does not own files or directories already owned by other packages. MUST: All filenames in rpm packages are valid UTF-8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #9 from Wes Hardaker wjhns174@hardakers.net 2011-11-01 16:26:14 EDT --- New Package SCM Request ======================= Package Name: lookup Short Description:A graphical tool to search DNS for answers Owners: hardaker Branches: f14 f15 f16 el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
Wes Hardaker wjhns174@hardakers.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
--- Comment #10 from Jesse Keating jkeating@redhat.com 2011-11-01 18:27:22 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748017
Paul Wouters pwouters@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE Last Closed| |2012-02-28 10:23:57
--- Comment #11 from Paul Wouters pwouters@redhat.com 2012-02-28 10:23:57 EST --- Wes forgot to close the review bug
package-review@lists.fedoraproject.org