https://bugzilla.redhat.com/show_bug.cgi?id=1113541
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Summary|Review Request: x11trace - |Rename Request: x11trace -
|Utility for tracing X11 |Utility for tracing X11
|protocol for debugging |protocol for debugging
Flags| |fedora-review?
--- Comment #2 from Parag AN(पराग) <panemade(a)gmail.com> ---
Review:
+ mock build is successful for rawhide
+ rpmlint output on rpms gave
x11trace.src: W: spelling-error %description -l en_US strace -> trace, traces,
strafe
x11trace.src: W: spelling-error %description -l en_US xtrace -> trace, x trace,
extract
x11trace.src: W: strange-permission xtrace_1.3.1.orig.tar.gz 0444L
x11trace.x86_64: W: spelling-error %description -l en_US strace -> trace,
traces, strafe
x11trace.x86_64: W: spelling-error %description -l en_US xtrace -> trace, x
trace, extract
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
+ Source verified with upstream as (sha256sum)
srpm tarball :
b22ca970efe24fcedff44f38075c5f34e0893f66abb419f3180ff92adf9e2a22
upstream tarball :
b22ca970efe24fcedff44f38075c5f34e0893f66abb419f3180ff92adf9e2a22
+ License "GPLv2" is valid and included in source files.
suggestions:
1) Package must own all directories that it creates. Note: Directories without
known owners: /usr/share/x11trace
==> fix this by changing
%{_datadir}/x11trace/*.proto
to
%{_datadir}/x11trace
2) you can change source tarball permission to 0644 before packaging to srpm
3) I see you have following which can be removed from spec
echo hello2
4) all your patche prefix names should start with package name i.e.
change xtrace to x11trace
5) Now the most important thing for a Rename package review is to follow
http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_E...
you will then need in your spec
Provides: xtrace = %{version}-%{release}
Obsoletes: xtrace < 1.3.1-7
also use the master branch spec only while renaming package. You should use
release number 7 and not 6
Fix above issues and submit new package for review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component