Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Config-Simple - Simple configuration file class
https://bugzilla.redhat.com/show_bug.cgi?id=426598
panemade(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade(a)gmail.com 2007-12-24 00:31 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
96513b61c7db591339ce2577878a3b32 Config-Simple-4.59.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/bug...............ok
t/create............ok
t/guess_syntax......ok
t/import............ok
t/ini...............ok
t/is_modified.......ok
t/read-rv...........ok
t/simple............ok
t/simplified-ini....ok
t/tie...............ok
All tests successful.
Files=10, Tests=89, 1 wallclock secs ( 0.33 cusr + 0.08 csys = 0.41 CPU)
+ Package perl-Config-Simple-4.59-2.fc9->
Provides: perl(Config::Simple) = 4.59
Requires: perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(Fcntl)
perl(Text::ParseWords) perl(strict) perl(vars)
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.