Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879365
Nils Philippsen <nphilipp(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nphilipp(a)redhat.com
--- Comment #2 from Nils Philippsen <nphilipp(a)redhat.com> ---
Sorry for the late reply, but my attempts to get rid of autofoo weren't too
fruitful, in the end I scrapped that approach and changed the spec file to only
build the GUI optionally and disabled that for F-18 and later.
(In reply to comment #1)
MUST items:
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistant macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - GPLv2+, via code
- License field in spec matches - OK
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum:
0751d4bd7e59c32626ba92fb3c3ff13d9207792b555b2720c61f35eda048ddb5
system-config-network-1.6.5.tar.bz2
? Can't find upstream.
I've uploaded the new 1.6.6 tarball to fedorahosted and put the complete source
URL into the spec file.
- Package needs ExcludeArch - N/A
- BuildRequires correct - ***
glibc-devel and gcc doesn't need to be explicitly listed
In fact, this doesn't compile anything, so they're possibly wrong.
Likely. Not even Harald could tell my why they were in. Removed.
The version on the python req can likely be removed
Ditto.
- Spec handles locales/find_lang - OK
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - ***
What happens if the help isn't installed? Perhaps it shouldn't be %doc.
They're only used in the GUI, i.e. removed %doc and moved to GUI-only parts
which are disabled.
- Headers/static libs in -devel subpackage. - N/A
- Package is a GUI app and has a .desktop file - OK... until it's removed.
Yes :-). Disabled/removed.
- Package compiles and builds on at least one arch. - OK (tested
x86_64)
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - OK
- No rpmlint output.
$ rpmlint system-config-network-tui-1.6.5-1.fc18.noarch.rpm
system-config-network-tui.noarch: E: explicit-lib-dependency python-iwlib
OK.
system-config-network-tui.noarch: W: self-obsoletion
redhat-config-network-tui <= 1.6.5 obsoletes redhat-config-network-tui =
1.6.5
Weird. Shouldn't it be <, not <= ?
I removed that ancient cruft.
system-config-network-tui.noarch: W: no-manual-page-for-binary
system-config-network-cmd
system-config-network-tui.noarch: W: no-manual-page-for-binary
system-config-network
system-config-network-tui.noarch: W: no-manual-page-for-binary
system-config-network-tui
1 packages and 0 specfiles checked; 1 errors, 4 warnings.
Warnings, OK.
$ rpmlint system-config-network-1.6.5-1.fc18.noarch.rpm
system-config-network.noarch: W: obsolete-not-provided rp3
Hah. Should just remove this.
Ditto.
system-config-network.noarch: W: self-obsoletion
redhat-config-network <=
1.6.5 obsoletes redhat-config-network = 1.6.5
See above.
system-config-network.noarch: W: no-manual-page-for-binary
system-control-network
system-config-network.noarch: W: no-manual-page-for-binary
system-config-network-gui
OK.
- final provides and requires are sane: ***
Requires:
initscripts >= 0:5.99
I think we don't need this version any more.
Removed version.
python
Given we have /usr/bin/python in requires (and rpm-python, and dbus-python,
and ...), this is superfluous.
Yes.
Provides:
internet-config = 0.40-2.1
isdn-config = 0.18-10.70.1
netcfg = 2.36-3p.1
netconf = 0.1-1.1
netconfig = 0.8.24-1.2.2.1.1
These are all *ancient*. Are they still required to be provided?
I removed them along with the ancient obsoletes from above.
SHOULD Items:
- Should build in mock. - OK (tested x86_64)
- Should build on all supported archs - didn't check
- Should function as described. - didn't check
- Should have sane scriptlets. - OK (none)
- Should have subpackages require base package with fully versioned depend.
- OK
- Should have dist tag - OK
- Should package latest version -OK, I guess
Suggestions:
1) Don't mark the help as %doc
2) Change the obsoletes from <= to <
3) Remove assorted obsoletes provides/requires
Find the changed spec file and SRPM (from a scratch build) at:
https://pkgs.fedoraproject.org/cgit/system-config-network.git/plain/syste...
http://kojipkgs.fedoraproject.org//work/tasks/6656/4786656/system-config-...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=aVvC57thgl&a=cc_unsubscribe