https://bugzilla.redhat.com/show_bug.cgi?id=1419030
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 addresses are Ok.
Source archive (SHA-256:
6666f8103cfa6beb2bc71a20f2686bd98bbd5edf1e9df9d60e0a6dc2b7f3293a) is original.
Ok.
Summary verified from lib/Return/Type.pm. Ok.
Description verified from lib/Return/Type.pm. Ok.
License verified from lib/Return/Type.pm, t/03coerce.t, t/02sugar.t,
t/01basic.t, README, LICENSE, COPYRIGHT, CONTRIBUTING. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.17'
(Makefile.PL:2).
TODO: Package CREDITS file as a documentation.
B::Deparse is not used. Ok.
Benchmark::Report::GitHub is not used. Ok.
All tests pass. Ok.
$ rpmlint perl-Return-Type.spec ../SRPMS/perl-Return-Type-0.005-1.fc26.src.rpm
../RPMS/noarch/perl-Return-Type-0.005-1.fc26.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Return-Type-0.005-1.fc26.noarch.rpm
drwxr-xr-x 2 root root 0 Feb 9 16:57
/usr/share/doc/perl-Return-Type
-rw-r--r-- 1 root root 809 Sep 8 2014
/usr/share/doc/perl-Return-Type/Changes
-rw-r--r-- 1 root root 3689 Sep 8 2014
/usr/share/doc/perl-Return-Type/README
drwxr-xr-x 2 root root 0 Feb 9 16:57
/usr/share/licenses/perl-Return-Type
-rw-r--r-- 1 root root 1234 Sep 8 2014
/usr/share/licenses/perl-Return-Type/COPYRIGHT
-rw-r--r-- 1 root root 18349 Sep 8 2014
/usr/share/licenses/perl-Return-Type/LICENSE
-rw-r--r-- 1 root root 2761 Feb 9 16:57
/usr/share/man/man3/Return::Type.3pm.gz
drwxr-xr-x 2 root root 0 Feb 9 16:57
/usr/share/perl5/vendor_perl/Return
-rw-r--r-- 1 root root 6686 Sep 8 2014
/usr/share/perl5/vendor_perl/Return/Type.pm
File layout and permission are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Return-Type-0.005-1.fc26.noarch.rpm
| sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.24.1)
1 perl(:VERSION) >= 5.8.0
1 perl(Attribute::Handlers)
1 perl(Eval::TypeTiny)
1 perl(strict)
1 perl(Sub::Util)
1 perl(Types::Standard)
1 perl(Types::TypeTiny)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: There is an optional dependency on Scope::Upper (lib/Return/Type.pm:65).
I recommend to declare it using Suggests or Recommends tag.
$ rpm -q --provides -p ../RPMS/noarch/perl-Return-Type-0.005-1.fc26.noarch.rpm
| sort -f | uniq -c
1 perl(Return::Type) = 0.005
1 perl-Return-Type = 0.005-1.fc26
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Return-Type-0.005-1.fc26.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F26
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=17692754). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the `TODO' items before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component