https://bugzilla.redhat.com/show_bug.cgi?id=1499109
Bug ID: 1499109 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: digimer@alteeve.ca QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://www.alteeve.com/an-repo/files/packages/perl-Log-Journald.spec SRPM URL: https://www.alteeve.com/an-repo/files/packages/perl-Log-Journald-0.20-2.fc26... Description: Log::Journald perl module (see: http://search.cpan.org/~lkundrak/Log-Journald/lib/Log/Journald.pm) Fedora Account System Username: digimer
https://bugzilla.redhat.com/show_bug.cgi?id=1499109
digimer digimer@alteeve.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <main |Review Request: |package name here> - <short |perl-Log-Journald - perl |summary here> |Log::Journald module for | |faster logging to journald
https://bugzilla.redhat.com/show_bug.cgi?id=1499109
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@v3.sk Assignee|nobody@fedoraproject.org |lkundrak@v3.sk Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1499109
--- Comment #1 from Lubomir Rintel lkundrak@v3.sk --- 1.) The SPEC file needs some modernizing, in particular removal of obsolete bits:
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRoot tag is no longer used.
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
I don't think MODULE_COMPAT makes sense anymore -- libperl now has a properly versioned SONAME and thus a sufficient dependency gets generated.
%install -rm -rf $RPM_BUILD_ROOT
The buildroot shouldn't be cleaned anymore.
-%clean -rm -rf $RPM_BUILD_ROOT
The %clean section is no longer used.
-%defattr(-,root,root,-)
%defattr is for making the files owned by root is not needed anymore.
2.) The source file you've bundled with your src.rpm does nor correspond to the upstream source.
Please turn the changes into a Patch file and apply it with %patch macro.
package-review@lists.fedoraproject.org