Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libldb - A schema-less, ldap like, API and database
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Summary: Review Request: libldb - A schema-less, ldap like, API and database Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sgallagh@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://fedorapeople.org/~sgallagh/ldb/libldb.spec SRPM URL: http://fedorapeople.org/~sgallagh/ldb/libldb-0.9.6-21.fc12.src.rpm Description: An extensible library that implements an LDAP like API to access remote LDAP servers, or use local tdb databases.
Additional information: the LDB is currently available in Fedora, however it is built as a subpackage of the samba4 SRPM. This new package request extracts the sources necessary to build the LDB on its own, so we do not need to carry in the entirety of samba4.
This package is a dependency for the SSSD, which will be packaged for EPEL5 soon.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
--- Comment #1 from Stephen Gallagher sgallagh@redhat.com 2010-02-25 14:35:08 EST --- Simo alerted me that there was a newer upstream version of libldb available. Better to work from that.
Spec URL: http://fedorapeople.org/~sgallagh/ldb/libldb.spec SRPM URL: http://fedorapeople.org/~sgallagh/ldb/libldb-0.9.10-23.fc12.src.rpm
It has been scratch-built in Koji successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=2014396
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Simo Sorce ssorce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ssorce@redhat.com
--- Comment #2 from Simo Sorce ssorce@redhat.com 2010-02-25 14:45:41 EST --- rpmlint output
$ rpmlint libldb.spec libldb.spec: W: invalid-url Source0: libldb-0.9.10.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
--- Comment #3 from Simo Sorce ssorce@redhat.com 2010-02-25 14:53:19 EST --- Looks like the prepping of the %install step does not conform to guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines
Removal of the build root is absent (required for EPEL, not required for Fedora
10
%{buildroot} should be preferred to $RPM_BUILD_ROOT so that variables are used consistently throughout the spec file.
The rest looks good to me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
--- Comment #4 from Simo Sorce ssorce@redhat.com 2010-02-25 14:59:34 EST --- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability)
the devel package seem to be failing this rule.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
--- Comment #5 from Stephen Gallagher sgallagh@redhat.com 2010-02-25 15:09:50 EST --- Buildroot, %install and pkgconfig concerns have been addressed.
Spec URL: http://fedorapeople.org/~sgallagh/ldb/libldb.spec SRPM URL: http://fedorapeople.org/~sgallagh/ldb/libldb-0.9.10-24.fc12.src.rpm
It has been scratch-built in Koji successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=2014517
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Nalin Dahyabhai nalin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nalin@redhat.com
--- Comment #6 from Nalin Dahyabhai nalin@redhat.com 2010-02-25 15:56:12 EST --- (In reply to comment #4)
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability)
the devel package seem to be failing this rule.
To be fair, RPM's been inserting this automatically since F10.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
--- Comment #7 from Simo Sorce ssorce@redhat.com 2010-02-25 16:41:26 EST --- (In reply to comment #6)
(In reply to comment #4)
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability)
the devel package seem to be failing this rule.
To be fair, RPM's been inserting this automatically since F10.
Sorry, docs still say it is required so I simply applied the rule :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Simo Sorce ssorce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
--- Comment #8 from Simo Sorce ssorce@redhat.com 2010-02-25 17:37:53 EST --- forgot to set review flag, doing now
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Simo Sorce ssorce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #9 from Simo Sorce ssorce@redhat.com 2010-03-08 13:59:58 EST --- package looks good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |sgallagh@redhat.com Flag| |needinfo?, fedora-cvs?
--- Comment #10 from Stephen Gallagher sgallagh@redhat.com 2010-03-08 14:08:14 EST --- New Package CVS Request ======================= Package Name: libldb Short Description: A schema-less, ldap like, API and database Owners: sgallagh Branches: EL-5 InitialCC:
Special requests: this package requires an EL-5 buildroot override to include libtalloc, libdtdb and libtevent (all of which are currently still in EL-5 updates-testing)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
--- Comment #11 from Kevin Fenzi kevin@tummy.com 2010-03-09 01:17:52 EST --- CVS done (by process-cvs-requests.py).
Please remember to dead.package and follow the end of life procedure if you don't want to ever build this on devel.
For the overrides, please file a rel-eng trac ticket with what you need in the override. Make sure to use the EPEL component.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE Flag|needinfo? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #12 from Stephen Gallagher sgallagh@redhat.com 2011-01-17 12:00:40 EST --- Package Change Request ====================== Package Name: libldb New Branches: devel Owners: sgallagh, simo InitialCC: ssorce@redhat.com
This package currently exists only as a backport for EL5, because it was previously carried as a subpackage of Samba. Upstream is now releasing this library independently, so we'd like to get it into rawhide. Rawhide was dead.packaged, retired and orphaned previously.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568428
--- Comment #13 from Jens Petersen petersen@redhat.com 2011-01-18 01:52:29 EST --- I think that needs to go through a fresh package review.
package-review@lists.fedoraproject.org