Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Bug ID: 890438 Summary: Review Request: libkscreen - KDE Display Management library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: dvratil@redhat.com
Spec URL: http://pub.progdan.cz/specs/libkscreen.spec SRPM URL: http://pub.progdan.cz/specs/libkscreen-20121226gitecc8d1a-1.fc18.src.rpm Description: LibKScreen is a library to access and change current configuration of displays. Fedora Account System Username: dvratil
Successful Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4820851
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #1 from Mario Blättermann mario.blaettermann@gmail.com --- Source0: libkscreen-%{version}.tar.xz has to be a downloadable URL. You are using a Git checkout, that's why no static URL is available. In this case you have to provide instructions how to get the source tarball. In general, you should follow the instructions for the naming of such checkouts: http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/Namin...
rm -rf $RPM_BUILD_ROOT is an artifact from older Fedora releases. Drop it, unless you want to provide your package for EPEL5 (impossible anyway due to missing BuildRequires there).
URL: http://www.kde.org Is it possible to provide a more specific URL?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |890439 (KScreen)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997 (kde-reviews) Alias| |libkscreen
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #2 from Dan Vrátil dvratil@redhat.com --- Spec URL: http://pub.progdan.cz/specs/libkscreen.spec SRPM URL: http://pub.progdan.cz/specs/libkscreen-0.9.0-1.20121228git.fc18.src.rpm
* Fri Dec 28 2012 Dan Vrátil dvratil@redhat.com 0.9.0-1.20121228git - Fixed versioning - Added instructions how to retrieve sources - Fixed URL - Removed 'rm -rf $RPM_BUILD_ROOT'
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jgrulich@redhat.com Assignee|nobody@fedoraproject.org |jgrulich@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #3 from Jan Grulich jgrulich@redhat.com --- Should be okay now.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Dan Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Dan Vrátil dvratil@redhat.com --- New Package SCM Request ======================= Package Name: libkscreen Short Description: KDE Display Management Library Owners: dvratil Branches: f17 f18 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #5 from Kevin Fenzi kevin@scrye.com --- Git done (by process-git-requests).
jgrulich: when doing reviews, could you do some basic checks, add rpmlint output, etc? (Or use the fedora-review tool as a base)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- libkscreen-0.9.0-1.20121228git.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libkscreen-0.9.0-1.20121228git.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- libkscreen-0.9.0-1.20121228git.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libkscreen-0.9.0-1.20121228git.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- libkscreen-0.9.0-1.20121228git.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #9 from Mario Blättermann mario.blaettermann@gmail.com --- There's no Rawhide package available yet, which I could use for a Koji build of kscreen.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-11 18:47:48
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- libkscreen-0.9.0-1.20121228git.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890438
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- libkscreen-0.9.0-1.20121228git.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org