[Bug 821727] New: Review Request: dolfin - the C++/Python interface of FEniCS - package-review

List overview All Threads
Download

newer

[Bug 821727] New: Review Request: dolfin - the C++/Python interface of FEniCS

older

[Bug 505154] Tracker: Review...

Red Hat Bugzilla

15 May 2012 15 May '12

2:07 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Summary: Review Request: dolfin - the C++/Python interface of FEniCS Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jonathan.underwood@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---

Spec URL: http://jgu.fedorapeople.org/dolfin.spec SRPM URL: http://jgu.fedorapeople.org/dolfin-1.0.0-0.1.el6.src.rpm Description: DOLFIN is the C++/Python interface of FEniCS, providing a consistent PSE (Problem Solving Environment) for ordinary and partial differential equations.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

15 May 15 May

2:07 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Jonathan Underwood jonathan.underwood@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |dolfin

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:13 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Jonathan Underwood jonathan.underwood@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |820660(FEniCS)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:14 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Jonathan Underwood jonathan.underwood@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

16 May 16 May

1:07 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821727

--- Comment #1 from Jonathan Underwood jonathan.underwood@gmail.com 2012-05-16 08:07:01 EDT --- Spec URL: http://jgu.fedorapeople.org/dolfin.spec SRPM URL: http://jgu.fedorapeople.org/dolfin-1.0.0-0.2.el6.src.rpm

* Wed May 15 2012 Jonathan G. Underwood jonathan.underwood@gmail.com - 1.0.0-0.2 - Added fully versioned Requires including %%{_isa} to the -devel packages - Removed unececessary Requires of the -openmpi and -mpich packages on the dolfin package - Added Requires for boost-devel and suitesparse-devel to the devel packages - Fix conditional tests for rhel 6 in spec file - Move the /share/dolfin/cmake directories to the -devel packages

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:07 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821727

--- Comment #2 from Jonathan Underwood jonathan.underwood@gmail.com 2012-05-16 08:07:53 EDT --- 1.0.0-0.2 also includes an extra patch to fix up the paths in the dolfin-config.cmake files

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:11 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821727

--- Comment #3 from Jonathan Underwood jonathan.underwood@gmail.com 2012-05-16 09:11:04 EDT --- Spec URL: http://jgu.fedorapeople.org/dolfin.spec SRPM URL: http://jgu.fedorapeople.org/dolfin-1.0.0-0.3.el6.src.rpm

* Wed May 15 2012 Jonathan G. Underwood jonathan.underwood@gmail.com - 1.0.0-0.3 - Added Requires: libxml2-devel, armadillo-devel to the -devel packages - Added Requires: boost-mpich2-devel to the -mpich2-devel package - Added Requires: boost-openmpi-devel to the -openmpi-devel package - Re-added a Requires for the main package to the -openmpi and -mpich2 package

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Oct 5 Oct

9:25 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Bug 821727 depends on bug 693158, which changed state.

Bug 693158 Summary: Review Request: python-viper - A minimalistic scientific plotter and run-time visualization module https://bugzilla.redhat.com/show_bug.cgi?id=693158

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

15 Oct 15 Oct

10:20 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Ryan Curtin ryan@igglybob.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |ryan@igglybob.com

--- Comment #4 from Ryan Curtin ryan@igglybob.com --- Hello there,

This is an unofficial review. Instead of pasting all the items which passed the guidelines successfully (like a lot of reviews) I prefer to just post the issues; it's shorter that way.

...

MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.

rpmlint is very noisy. Many of these problems I may address later on, but for now here is a dump of the output.

Checking: dolfin-openmpi-devel-1.0.0-0.3.fc17.i686.rpm dolfin-1.0.0-0.3.fc17.i686.rpm dolfin-mpich2-devel-1.0.0-0.3.fc17.i686.rpm dolfin-mpich2-1.0.0-0.3.fc17.i686.rpm dolfin-doc-1.0.0-0.3.fc17.i686.rpm dolfin-openmpi-1.0.0-0.3.fc17.i686.rpm dolfin-devel-1.0.0-0.3.fc17.i686.rpm dolfin-1.0.0-0.3.fc17.src.rpm dolfin-debuginfo-1.0.0-0.3.fc17.i686.rpm dolfin-openmpi-devel.i686: I: enchant-dictionary-not-found en_US dolfin-openmpi-devel.i686: W: only-non-binary-in-usr-lib dolfin-openmpi-devel.i686: W: no-documentation dolfin-openmpi-devel.i686: E: non-executable-script /usr/lib/openmpi/share/dolfin/demo/undocumented/quadrature/python/demo_quadrature.py 0644L /usr/bin/env dolfin.i686: W: name-repeated-in-summary C DOLFIN dolfin.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/dolfin/_cpp.so dolfin.i686: E: binary-or-shlib-defines-rpath /usr/lib/python2.7/site-packages/dolfin/_cpp.so ['/builddir/build/BUILD/dolfin-1.0.0/serial/dolfin'] dolfin.i686: W: shared-lib-calls-exit /usr/lib/libdolfin.so.1.0.0 exit@GLIBC_2.0 dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env dolfin-mpich2-devel.i686: W: only-non-binary-in-usr-lib dolfin-mpich2-devel.i686: W: no-documentation dolfin-mpich2-devel.i686: E: non-executable-script /usr/lib/mpich2/share/dolfin/demo/undocumented/quadrature/python/demo_quadrature.py 0644L /usr/bin/env dolfin-mpich2.i686: W: shared-lib-calls-exit /usr/lib/mpich2/lib/libdolfin.so.1.0.0 exit@GLIBC_2.0 dolfin-mpich2.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/mpich2/dolfin/_cpp.so dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-convert.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-convert.1.gz dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-order.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-order.1.gz dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-plot.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-plot.1.gz dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-version.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-version.1.gz dolfin-doc.i686: W: hidden-file-or-dir /usr/share/doc/dolfin-doc-1.0.0/sphinx-python/build/html/.buildinfo dolfin-doc.i686: W: hidden-file-or-dir /usr/share/doc/dolfin-doc-1.0.0/sphinx-cpp/build/html/.buildinfo dolfin-doc.i686: W: doc-file-dependency /usr/share/doc/dolfin-doc-1.0.0/sphinx-python/source/demo/undocumented/quadrature/python/demo_quadrature.py /usr/bin/env dolfin-openmpi.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/openmpi/dolfin/_cpp.so dolfin-openmpi.i686: W: shared-lib-calls-exit /usr/lib/openmpi/lib/libdolfin.so.1.0.0 exit@GLIBC_2.0 dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-convert.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-convert.1.gz dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-order.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-order.1.gz dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-plot.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-plot.1.gz dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-version.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-version.1.gz dolfin-devel.i686: W: no-documentation dolfin-devel.i686: E: non-executable-script /usr/share/dolfin/demo/undocumented/quadrature/python/demo_quadrature.py 0644L /usr/bin/env dolfin.src: W: name-repeated-in-summary C DOLFIN dolfin.src:337: W: macro-in-comment %if dolfin.src:341: W: macro-in-comment %else dolfin.src:342: W: macro-in-comment %{_mandir} dolfin.src:342: W: macro-in-comment %{_arch} dolfin.src:343: W: macro-in-comment %endif dolfin.src:47: W: mixed-use-of-spaces-and-tabs (spaces: line 47, tab: line 27) 9 packages and 0 specfiles checked; 21 errors, 30 warnings.

(( ryan @ samedi )) ~/review-work/dolfin $ rpmlint dolfin dolfin.i686: W: name-repeated-in-summary C DOLFIN dolfin.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/dolfin/_cpp.so dolfin.i686: E: binary-or-shlib-defines-rpath /usr/lib/python2.7/site-packages/dolfin/_cpp.so ['/builddir/build/BUILD/dolfin-1.0.0/serial/dolfin'] dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /lib/libboost_thread-mt.so.1.48.0 dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /lib/libboost_math_tr1-mt.so.1.48.0 dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /lib/libamd.so.2 dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /lib/libblas.so.3 dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /lib/libcamd.so.2 dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /lib/libcolamd.so.2 dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /lib/libccolamd.so.2 dolfin.i686: W: unused-direct-shlib-dependency /usr/lib/libdolfin.so.1.0.0 /usr/lib/atlas/liblapack.so.3 dolfin.i686: W: shared-lib-calls-exit /usr/lib/libdolfin.so.1.0.0 exit@GLIBC_2.0 dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 4 errors, 11 warnings.

(( ryan @ samedi )) ~/review-work/dolfin $ LD_LIBRARY_PATH="/usr/lib/openmpi/lib/" rpmlint dolfin-openmpi dolfin-openmpi.i686: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment dolfin-openmpi.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/openmpi/dolfin/_cpp.so dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libboost_thread-mt.so.1.48.0 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libboost_math_tr1-mt.so.1.48.0 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libamd.so.2 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libblas.so.3 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libcamd.so.2 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libcolamd.so.2 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libccolamd.so.2 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /usr/lib/atlas/liblapack.so.3 dolfin-openmpi.i686: W: unused-direct-shlib-dependency /usr/lib/openmpi/lib/libdolfin.so.1.0.0 /lib/libdl.so.2 dolfin-openmpi.i686: W: shared-lib-calls-exit /usr/lib/openmpi/lib/libdolfin.so.1.0.0 exit@GLIBC_2.0 dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-convert.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-convert.1.gz dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-order.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-order.1.gz dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-plot.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-plot.1.gz dolfin-openmpi.i686: E: invalid-locale-man-dir /usr/share/man/openmpi-i386/man1/dolfin-version.1.gz dolfin-openmpi.i686: W: file-not-in-%lang /usr/share/man/openmpi-i386/man1/dolfin-version.1.gz 1 packages and 0 specfiles checked; 7 errors, 16 warnings.

(( ryan @ samedi )) ~/review-work/dolfin $ LD_LIBRARY_PATH="/usr/lib/mpich2/lib/" rpmlint dolfin-mpich2 dolfin-mpich2.i686: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /lib/libboost_thread-mt.so.1.48.0 dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /lib/libboost_math_tr1-mt.so.1.48.0 dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /lib/libamd.so.2 dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /lib/libblas.so.3 dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /lib/libcamd.so.2 dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /lib/libcolamd.so.2 dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /lib/libccolamd.so.2 dolfin-mpich2.i686: W: unused-direct-shlib-dependency /usr/lib/mpich2/lib/libdolfin.so.1.0.0 /usr/lib/atlas/liblapack.so.3 dolfin-mpich2.i686: W: shared-lib-calls-exit /usr/lib/mpich2/lib/libdolfin.so.1.0.0 exit@GLIBC_2.0 dolfin-mpich2.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/mpich2/dolfin/_cpp.so dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-convert.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-convert.1.gz dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-order.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-order.1.gz dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-plot.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-plot.1.gz dolfin-mpich2.i686: E: invalid-locale-man-dir /usr/share/man/mpich2/man1/dolfin-version.1.gz dolfin-mpich2.i686: W: file-not-in-%lang /usr/share/man/mpich2/man1/dolfin-version.1.gz 1 packages and 0 specfiles checked; 7 errors, 15 warnings.

...

MUST: Development files must be in a -devel package.

The dolfin-doc package contains a large number of source files, which appear to be demo files. This seems okay to me, but it may be worth going through all those files and ensuring that only examples are included in the doc subpackage. To me it looks like many of the demo source files (such as, perhaps 'sphinx-cpp/source/demo/undocumented/periodic/cpp/Poisson.h) may not actually be necessary in that package.

In addition, the dolfin-devel package seems to both include the headers in /usr/include as well as a bunch of demos in /usr/share/dolfin/demo. I am not sure the demos are necessary in the devel subpackage and I would suggest that they should appear only in the doc subpackage.

...

MUST Rpath absent or only used for internal libs.

...

From rpmlint:

...

dolfin-openmpi.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/openmpi/dolfin/_cpp.so dolfin-mpich2.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/mpich2/dolfin/_cpp.so dolfin.i686: W: unstripped-binary-or-object /usr/lib/python2.7/site-packages/dolfin/_cpp.so

CMake should automatically be stripping at install-time, so I am not sure what is happening here.

...

%description DOLFIN is the C++/Python interface of FEniCS, providing a consistent PSE (Problem Solving Environment) for ordinary and partial differential equations.

This could be rewrapped to have fewer lines and still be fewer than 80 characters per line. Yes, that is pedantry... sorry...

To be even more unnecessarily pedantic, many of the subpackage descriptions do not have punctuation at the end of the sentences.

...

MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.

The rpmlint output from earlier lists a couple files with potentially incorrect permissions.

dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin.i686: E: non-executable-script /usr/lib/python2.7/site-packages/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env

dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin-openmpi.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openmpi/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env

dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/torque.py 0644L /usr/bin/env dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/sge.py 0644L /usr/bin/env dolfin-mpich2.i686: E: non-executable-script /usr/lib/python2.7/site-packages/mpich2/dolfin_utils/pjobs/pjobs.py 0644L /usr/bin/env

...

SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.

This package has no LICENSE file; just wanted to point that out.

...

[!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

It looks like you are packaging for EPEL5, due to the cmake28 macro bits, so %{buildroot} should be defined.

...

[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

Somewhat self-explanatory.

...

[!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 See: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5

That should be simple to fix.

The package seems to build okay and a very simple test seems to indicate that it runs properly, too.

Hopefully this review is helpful...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7 Jan 7 Jan

4:06 a.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821727

Bug 821727 depends on bug 799702, which changed state.

Bug 799702 Summary: Review Request: python-ufl - A compiler for finite element variational forms https://bugzilla.redhat.com/show_bug.cgi?id=799702

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qgpCQgYFCM&a=cc_unsubscribe

Red Hat Bugzilla

11:17 a.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821727

--- Comment #5 from Jonathan Underwood jonathan.underwood@gmail.com --- Thanks, I hope to find some time to get back to this in the next week or so.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=88uH3KF5sh&a=cc_unsubscribe

Red Hat Bugzilla

23 Jan 23 Jan

4:21 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821727

Jonathan Underwood jonathan.underwood@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |903285

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T3UQ92fLP2&a=cc_unsubscribe

Red Hat Bugzilla

24 Jan 24 Jan

3:18 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821727

Bug 821727 depends on bug 820659, which changed state.

Bug 820659 Summary: Review Request: python-ufc - Unified Form-assembly Code https://bugzilla.redhat.com/show_bug.cgi?id=820659

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mdK5BVGnb3&a=cc_unsubscribe

Red Hat Bugzilla

4 Sep 4 Sep

3:03 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Christopher Meng cickumqt@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s16qhfyrjc&a=cc_unsubscribe

Red Hat Bugzilla

31 Jul 31 Jul

1:31 a.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Christopher Meng i@cicku.me changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On|903285 (python-viper) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=903285 [Bug 903285] Review Request: python-viper - A minimalistic scientific plotter and run-time visualization module

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

7 Oct 7 Oct

10:24 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@math.uh.edu

--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu --- I happen to have a user who wants this software, and so might be willing to commit a bit of time to moving this forward. Did you want to try and update it as you indicated in comment 6?

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

8 Oct 8 Oct

10:58 a.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

--- Comment #8 from Jonathan Underwood jonathan.underwood@gmail.com --- Hi Jason, I'm afraid my job role has changed and I don't have a need or the time for packaging the Fenics stack at present. It shouldn't actually be too much work now though - the other components are packaged and have been updated recently, and this package is a good starting point, along with the unofficial review from Ryan above.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

31 Mar 31 Mar

11:49 a.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Jonathan Underwood jonathan.underwood@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |505154 (FE-SCITECH)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

17 Apr 17 Apr

7:34 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu

--- Comment #9 from Rex Dieter rdieter@math.unl.edu --- I'm in the same boat as Jason, does comment #8 imply you're not able/willing to proceed as package submitter/maintainer?

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

8:47 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

--- Comment #10 from Jonathan Underwood jonathan.underwood@gmail.com --- I am afraid I don't have time to maintain this package on my own, no. I'd be willing to review the package if someone else wanted to lead the charge. I'd love to see it in Fedora as I put quite a lot of time into the packaging in the past, but, I don't have enough bandwidth to maintain the Fenics stack when I'm no longer using it myself, sorry.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

29 Jul 29 Jul

7:38 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Jonathan Underwood jonathan.underwood@gmail.com changed:

--- Comment #11 from Jonathan Underwood jonathan.underwood@gmail.com --- OK, I am going to close this as WONTFIX, feel free to re-open/clone if you want to pick it up.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

14 Aug 14 Aug

7:34 p.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727 Bug 821727 depends on bug 693137, which changed state.

Bug 693137 Summary: Review Request: python-ffc - A compiler for finite element variational forms https://bugzilla.redhat.com/show_bug.cgi?id=693137

-- You are receiving this mail because: You are always notified about changes to this product and component

bugzilla＠redhat.com

7 Feb 7 Feb

4:33 a.m.

New subject: [Bug 821727] Review Request: dolfin - the C++/Python interface of FEniCS

https://bugzilla.redhat.com/show_bug.cgi?id=821727

Susi Lehtola susi.lehtola@iki.fi changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|505154 (FE-SCITECH) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages

-- You are receiving this mail because: You are always notified about changes to this product and component

2776

Age (days ago)

4505

Last active (days ago)

package-review@lists.fedoraproject.org

22 comments

2 participants

tags (0)

participants (2)

bugzilla＠redhat.com
Red Hat Bugzilla