https://bugzilla.redhat.com/show_bug.cgi?id=1649794
Bug ID: 1649794 Summary: Review Request: golang-github-fogleman-gg - Go Graphics - 2D rendering in Go with a simple API Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhi...
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhi...
Description: Go Graphics - 2D rendering in Go with a simple API
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Long time no see, I hope you're doing great!
- Latest version packaged - License ok - Builds in Mock - Conforms to the Packaging Guidelines
There are missing packages:
DEBUG util.py:490: BUILDSTDERR: Problem: conflicting requests DEBUG util.py:490: BUILDSTDERR: - nothing provides golang(github.com/golang/freetype/raster) needed by golang-github-fogleman-gg-devel-1.1.0-1.20181114git0e0ff3a.fc30.noarch DEBUG util.py:490: BUILDSTDERR: - nothing provides golang(github.com/golang/freetype/truetype) needed by golang-github-fogleman-gg-devel-1.1.0-1.20181114git0e0ff3a.fc30.noarch
You probably need to package github.com/golang/freetype for it to work.
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #2 from sensor.wen@gmail.com --- Hi Robert:
I think the golang(github.com/BurntSushi/freetype-go) is equal to the golang(github.com/golang/freetype) package. So i update it to provides alias. ( https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go/c/29... )
Unfortunately, Koji tell me the golang-github-freetype package not in list for tag f30-pending. Do i need to resubmit request for pkg_review?
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com ---
Unfortunately, Koji tell me the golang-github-freetype package not in list for tag f30-pending. Do i need to resubmit request for pkg_review?
That's because you changed the name of the package!
Name: %{goname}
You can't do that!
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- If you want to rename the package you must resubmut a review with the new name and retire the old one.
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- - You must install the license with %license in %files:
%license LICENSE.md
- The license field s wrong: it should be MIT, not GPLv3
I fixed the freetype package and requested buildroot override for each release.
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #6 from sensor.wen@gmail.com ---
- You must install the license with %license in %files:
%license LICENSE.md
- The license field s wrong: it should be MIT, not GPLv3
I fixed. https://github.com/FZUG/deepin-desktop/commit/90e6dc829eed65c1751226195bc155...
I fixed the freetype package and requested buildroot override for each release.
It's great! :)
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #7 from sensor.wen@gmail.com --- (In reply to Robert-André Mauchin from comment #5)
I fixed the freetype package and requested buildroot override for each release.
I'm going to take notes....
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #8 from Robert-André Mauchin zebob.m@gmail.com --- All right, package approved.
Buildroot override for F29 and F28 are done. F27 is still waiting: koji wait-repo f27-build --build=golang-github-BurntSushi-freetype-go-0-0.5.20181114gite2365df.fc27
https://bugzilla.redhat.com/show_bug.cgi?id=1649794
--- Comment #9 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-fogleman-gg
package-review@lists.fedoraproject.org