https://bugzilla.redhat.com/show_bug.cgi?id=2024917
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Doc Type|--- |If docs needed, set a value
Flags| |fedora-review+
CC| |zbyszek(a)in.waw.pl
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Patch0: %{name}--format-security.patch
Using a macro here is *allowed*, but why would one want to do this? For me it
does
nothing except making it impossible to easily open the file from an editor
which does
not understand rpm macros.
%description
It's broken at ~60-70 chars, should be 80 ;)
One thing that is missing is an appdata file [1]. Guidelines say "SHOULD", so
this is
not a blocker, but please consider adding one, as it will make graphical
installations
much easier, which is probably important for the class of users who use games.
[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
- package name is OK
- latest version (2012-03-19, yikes!)
- license is acceptable for Fedora (GPLv3+)
- license is specified correctly
- builds and installs correctly
- BR/R/P look OK
- runs OK:
The window shows and reacts to clicks, sounds and templates work.
rpmlint:
pipewalker.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/pipewalker/README
pipewalker.x86_64: W: no-manual-page-for-binary pipewalker
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
Nothing important.
I think it'd be nice to add some README. I couldn't figure out what the point
of the game was ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2024917