Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=582106
Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka(a)ioa.s.u-tokyo.ac.jp
--- Comment #1 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> 2010-05-01 14:36:20
EDT ---
Some notes:
* Using %name / %version macro in SourceURL
- Using %name / %version (especially %version) in SourceURL
is generally useful:
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D
* Debuginfo rpm
- Creating debuginfo rpm is a must and please fix this
! Note
build.log shows
------------------------------------------------------------------------------
77 g++ ../obj/*.o -O2 -s `pkg-config gtkmm-2.4 gconfmm-2.6 gtkspell-2.0
--cflags --libs` -lgcrypt -lgpg-error -o ../bin/lifeograph
------------------------------------------------------------------------------
and "-s" option strips the binary.
Passing 'LINKFLAGS=""' to make resolves this issue (for
this package).
* Timestamps
- This package installs many image files which are not modified during
rpmbuild and keeping timestamps on those files is recommended.
For this package, using
------------------------------------------------------------------------------
make debug install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
------------------------------------------------------------------------------
will keep timestamps on those files
! Note
- For this package I don't think src/makefile need modifying,
you can change the valiable used in src/makefile by passing
option to make like:
------------------------------------------------------------------------------
make %{?_smp_mflags} OPTFLAGS="%{optflags}" LINKFLAGS=""
------------------------------------------------------------------------------
and for install see above
* $RPM_BUILD_ROOT vs %buildroot
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot...
- Please choose one and don't use both.
* desktop-file-install / desktop-file-validate
- Once a desktop file is installed using desktop-file-install, there is
no need to use desktop-file-validate for the installed desktop file
(the installed desktop file is already verified).
* Directory ownership issue
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ow...
https://fedoraproject.org/wiki/Packaging/UnownedDirectories
- The following directories are not owned by any packages:
-----------------------------------------------------------------------------
%{_datadir}/pixmaps/lifeograph/
%{_datadir}/pixmaps/lifeograph/backgrounds/
-----------------------------------------------------------------------------
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.