Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
Summary: Review Request: xar - The eXtensible ARchiver Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: matthias@rpmforge.net QAContact: fedora-package-review@redhat.com
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/xar/xar.spec SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/xar/xar-1.5-1.src.rpm Description: The XAR project aims to provide an easily extensible archive format. Important design decisions include an easily extensible XML table of contents for random access to archived files, storing the toc at the beginning of the archive to allow for efficient handling of streamed archives, the ability to handle files of arbitrarily large sizes, the ability to choose independent encodings for individual files in the archive, the ability to store checksums for individual files in both compressed and uncompressed form, and the ability to query the table of content's rich meta-data.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
Jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |Jochen@herr-schmitt.de Flag| |fedora-review?
------- Additional Comments From Jochen@herr-schmitt.de 2007-05-30 16:44 EST ------- Good: + Rpmlint quite on source rpm. + Sources matches with upstream. + License ok. + Naming ok. + Local build works fine. + Rpmlint quite on xar main package. + Rpmlint quite on debuginfo package. + Package contains varbatin copy of the license text. + Local install and uninstall works fine + Local test of the application works fine. + Mock build works fine.
Bad: - Bad Buildroot: BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Duplicate BuildRequites: Duplicate BuildRequires: zlib-devel (by libxml2-devel) - xar-devel contains no docs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
------- Additional Comments From matthias@rpmforge.net 2007-05-31 05:06 EST ------- - Buildroot : "should", not "must", I'm getting tired of this one :-/ - Duplicate buildrequires : Not really. The package checks explicitly for both, it's not if it was only relying on libxml2 and indirectly on zlib. I see no harm or problems in having both, and prefer like this in case the software switches to some other xml library in the future, which doesn't pull in zlib. - I don't recall any policy making docs mandatory in devel packages. You're probably relying on rpmlint output. The xar sources don't contain any API docs, so the devel package doesn't either.
Thanks for taking the time to review, and so quickly too :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
Jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From Jochen@herr-schmitt.de 2007-05-31 13:44 EST ------- Ok, for the Buildroot I have consult the packaging guildline and have find out, that you specified Buildroot is ok.
So, becouse there are no open topics noew, I can approve your package.
*** APPROVED ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
matthias@rpmforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-cvs?
------- Additional Comments From matthias@rpmforge.net 2007-06-05 18:52 EST ------- Thanks for the review! I had forgotten about it because the bug wasn't ASSIGNED, though.
New Package CVS Request ======================= Package Name: xar Short Description: The eXtensible ARchiver Owners: matthias@rpmforge.net Branches: F7 FC6 FC5 EL5 EL4 devel (all current) InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-06-05 19:17 EST ------- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
matthias@rpmforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From matthias@rpmforge.net 2007-06-07 03:20 EST ------- Thanks! All imported, built and pushed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
------- Additional Comments From updates@fedoraproject.org 2007-06-18 12:39 EST ------- xar-1.5-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xar - The eXtensible ARchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241758
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |1.5-1.fc7
package-review@lists.fedoraproject.org