https://bugzilla.redhat.com/show_bug.cgi?id=1761451
Bug ID: 1761451 Summary: Review-Request: kata-runtime - Kata runtime to run containers in virtual machines Product: Fedora Version: rawhide Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: dinechin@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pagure.io/fork/ddd/kata-rpm-reviews/raw/review-v2/f/kata-runtime/kat... SRPM URL: http://blackbox.dinechin.org/fedora/kata-runtime-1.8.2-3.fc32.src.rpm Description: Kata runtime to run containers in virtual machines Fedora Account System Username: ddd Copr build: https://copr.fedorainfracloud.org/coprs/ddd/kata/build/1052606/
https://bugzilla.redhat.com/show_bug.cgi?id=1761451
Christophe de Dinechin dinechin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |crobinso@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1761451
--- Comment #1 from Christophe de Dinechin dinechin@redhat.com --- Hi Cole, I had to re-create a BZ, because apparently there is a check that you are the creator of the BZ when you try to request a repo. See https://pagure.io/releng/fedora-scm-requests/issue/18178.
I reassigned the original BZ to myself, and tried again, that's https://pagure.io/releng/fedora-scm-requests/issue/18213, still pending. So maybe "creator" really means "assignee" (which would make more sense). But I also decided to create a BZ just in case that is necessary.
https://bugzilla.redhat.com/show_bug.cgi?id=1761451
Cole Robinson crobinso@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+
--- Comment #2 from Cole Robinson crobinso@redhat.com --- The content is identical to https://bugzilla.redhat.com/show_bug.cgi?id=1590425#c12 , which I reviewed there. So duplicating that content here and approving the review:
(In reply to Cole Robinson from comment #13)
The license/doc stuff is not doing what you think it's doing. There's only a single LICENSE file that ends up in the RPM:
$ rpm -qpl ./x86_64/kata-runtime-1.8.2-3.fc31.x86_64.rpm | grep LICENSE /usr/share/licenses/kata-runtime/LICENSE
Which LICENSE of the 3 mentioned? Not sure, maybe the first, but I didn't confirm.
And it does produce warnings: $ rpmbuild --rebuild ./srpm/kata-runtime-1.8.2-3.fc32.src.rpm ... warning: File listed twice: /usr/share/doc/kata-runtime/README.md warning: File listed twice: /usr/share/doc/kata-runtime/README.md warning: File listed twice: /usr/share/doc/kata-runtime/README.md warning: File listed twice: /usr/share/doc/kata-runtime/README.md warning: File listed twice: /usr/share/doc/kata-runtime/README.md warning: File listed twice: /usr/share/doc/kata-runtime/README.md warning: File listed twice: /usr/share/doc/kata-runtime/README.md warning: File listed twice: /usr/share/licenses/kata-runtime/LICENSE warning: File listed twice: /usr/share/licenses/kata-runtime/LICENSE ...
For some reason the review is also spitting out an Issue that wasn't there before, but I can't see what changed:
Issues:
- Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/kata-runtime/README.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files
But it seems related.
Otherwise this looks good to me. I'm approving the review but please find a solution to those issues before performing a first build. Next steps on your side are listed here: https://fedoraproject.org/wiki/Package_Review_Process#Contributor
https://bugzilla.redhat.com/show_bug.cgi?id=1761451
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kata-runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1761451
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-2d11c3738d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2d11c3738d
https://bugzilla.redhat.com/show_bug.cgi?id=1761451
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- kata-runtime-1.8.2-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2d11c3738d
https://bugzilla.redhat.com/show_bug.cgi?id=1761451
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-10-31 00:57:31
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- kata-runtime-1.8.2-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org