https://bugzilla.redhat.com/show_bug.cgi?id=2051372
Bug ID: 2051372 Summary: Review Request: the_foundation - Opinionated C11 library for low-level functionality Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/web/the_foundation.spec SRPM URL: https://salimma.fedorapeople.org/specs/web/the_foundation-1.1.0-1.fc35.src.r... Description: An object-oriented C library whose API is designed for a particular coding style, taking cues from C++ STL and Qt.}
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2051373
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2051373 [Bug 2051373] Review Request: lagrange - A Beautiful Gemini Client
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com ---
%{_libdir}/*.so.*
Soversions need to be listed and globbed properly.
Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_l...
Also note: https://pagure.io/packaging-committee/pull-request/1162
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- (In reply to Neal Gompa from comment #1)
%{_libdir}/*.so.*
Soversions need to be listed and globbed properly.
Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/ #_listing_shared_library_files
Also note: https://pagure.io/packaging-committee/pull-request/1162
updated, thanks. same URLs.
Going to look into updating the library template for rpmdev-newspec, since this is what tripped me up /even/ after just reading the packaging discussion a couple of days before.
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review+ Status|NEW |POST
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- Thanks!
~ ❯ fedpkg request-repo the_foundation 2051372 https://pagure.io/releng/fedora-scm-requests/issue/41857
~ took 6s ❯ fedpkg request-branch --repo the_foundation --all-releases https://pagure.io/releng/fedora-scm-requests/issue/41858 https://pagure.io/releng/fedora-scm-requests/issue/41859
~ took 5s ❯ fedpkg request-branch --repo the_foundation epel9 https://pagure.io/releng/fedora-scm-requests/issue/41860
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/the_foundation
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-652885bb89 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-652885bb89
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-2ef52450a5 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2ef52450a5
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2022-419af3b3d4 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-419af3b3d4
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2022-a88e3bffde has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-a88e3bffde
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-02-10 00:38:02
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2022-a88e3bffde has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2022-419af3b3d4 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-2ef52450a5 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-652885bb89 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-535004e389 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-535004e389
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-535004e389 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d5d803bb28 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d5d803bb28
https://bugzilla.redhat.com/show_bug.cgi?id=2051372
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d5d803bb28 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org