https://bugzilla.redhat.com/show_bug.cgi?id=1403734
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 are usable. Ok.
Source archive is original (SHA-256:
9d471d8e13e7ce4793d5a5ec04a60fface14dd53be78dd94d228871915cfd1f9). Ok.
Summary is Ok.
Description is Ok.
License verified from README, lib/Sub/Quote.pm. Ok.
TODO: I think the code should not build- and run-require both Sub::Name and
Sub::Util modules. I think both are optional and Sub::Name will not be used if
Sub::Util is available.
FIX: This package should conflict with perl-Moo < 2.003000 because the modules
and manual pages were provided with perl-Moo previously.
All tests pass. Ok.
$ rpmlint perl-Sub-Quote.spec ../SRPMS/perl-Sub-Quote-2.003001-1.fc26.src.rpm
../RPMS/noarch/perl-Sub-Quote-2.003001-1.fc26.noarch.rpm
perl-Sub-Quote.src: W: spelling-error Summary(en_US) eval -> veal, vela, val
perl-Sub-Quote.src: W: spelling-error %description -l en_US performant ->
perform ant, perform-ant, performance
perl-Sub-Quote.noarch: W: spelling-error Summary(en_US) eval -> veal, vela, val
perl-Sub-Quote.noarch: W: spelling-error %description -l en_US performant ->
perform ant, perform-ant, performance
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Sub-Quote-2.003001-1.fc26.noarch.rpm
drwxr-xr-x 2 root root 0 Dec 12 13:56
/usr/share/doc/perl-Sub-Quote
-rw-r--r-- 1 root root 242 Dec 9 09:20
/usr/share/doc/perl-Sub-Quote/Changes
-rw-r--r-- 1 root root 6740 Dec 9 09:20
/usr/share/doc/perl-Sub-Quote/README
-rw-r--r-- 1 root root 2040 Dec 12 13:56
/usr/share/man/man3/Sub::Defer.3pm.gz
-rw-r--r-- 1 root root 4133 Dec 12 13:56
/usr/share/man/man3/Sub::Quote.3pm.gz
drwxr-xr-x 2 root root 0 Dec 12 13:56
/usr/share/perl5/vendor_perl/Sub
-rw-r--r-- 1 root root 6230 Dec 9 09:20
/usr/share/perl5/vendor_perl/Sub/Defer.pm
-rw-r--r-- 1 root root 13507 Dec 9 09:20
/usr/share/perl5/vendor_perl/Sub/Quote.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Sub-Quote-2.003001-1.fc26.noarch.rpm
| sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.24.0)
1 perl(B)
1 perl(Carp)
1 perl(Exporter)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(Sub::Defer)
1 perl(Sub::Name) >= 0.08
1 perl(Sub::Util)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
TODO: Do not run-require both perl(Sub::Name) and perl(Sub::Util).
$ rpm -q --provides -p ../RPMS/noarch/perl-Sub-Quote-2.003001-1.fc26.noarch.rpm
| sort -f | uniq -c
1 perl(Sub::Defer) = 2.003001
1 perl(Sub::Quote) = 2.003001
1 perl-Sub-Quote = 2.003001-1.fc26
Binary provides are Ok.
Package builds in F26
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=16852699). Ok.
Otherwise the package in in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' items and consider fixing `TODO' items before building
this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component