Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-POE-Component-JobQueue
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198012
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs(a)math.uh.edu 2006-07-08 00:03 EST -------
Good idea packaging the test as an example.
* source files match upstream:
3abbef8df7527bdc4f8bf99005f3b567 POE-Component-JobQueue-0.5402.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is optional)
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* noarch package; no debuginfo.
* final provides and requires are sane:
perl(POE::Component::JobQueue) = 0.54
perl-POE-Component-JobQueue = 0.5402-0.fc6
=
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(POE::Session)
perl(strict)
perl(vars)
* %check is present and all tests pass:
All tests successful.
Files=1, Tests=3, 7 wallclock secs ( 0.06 cusr + 0.03 csys = 0.09 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.