https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Bug ID: 2022176 Summary: Review Request: system76-keyboard-configurator - System76 Keyboard Configurator Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: link@sub-pop.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... Description: Application for configuration of System76 keyboard firmware. Fedora Account System Username: linkdupont
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |gotmax@e.email
--- Comment #1 from Maxwell G gotmax@e.email --- (In reply to Link Dupont from comment #0)
Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... rawhide-x86_64/02948977-system76-keyboard-configurator/system76-keyboard- configurator.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... rawhide-x86_64/02948977-system76-keyboard-configurator/system76-keyboard- configurator-1.0.0-1.fc36.src.rpm
These links are broken.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #2 from Link Dupont link@sub-pop.net --- Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #3 from Link Dupont link@sub-pop.net --- (In reply to Maxwell G from comment #1)
These links are broken.
Yes, thank you for pointing that out. A number of my review bugs will have missing links at this point; I had to rebuild some of them.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #4 from Neal Gompa ngompa13@gmail.com ---
Requires: %{name} == %{version}-%{release}
I'm not sure "==" is valid, I think you need to use "=" instead.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #5 from Link Dupont link@sub-pop.net --- (In reply to Neal Gompa from comment #4)
Requires: %{name} == %{version}-%{release}
I'm not sure "==" is valid, I think you need to use "=" instead.
Oops. You're right. Good catch.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #6 from Neal Gompa ngompa13@gmail.com ---
BuildRequires: libudev-devel BuildRequires: hidapi-devel [...] BuildRequires: (crate(hidapi/linux-static-hidraw) >= 1.2.0 with crate(hidapi/linux-static-hidraw) < 2.0.0~)
This should be changed to use the "linux-shared-hidraw" feature instead in the backend Cargo.toml: https://github.com/pop-os/keyboard-configurator/blob/666266c60c89186b829efdf...
That will also let you drop hidapi-devel BR here (and probably libudev-devel BR too) since the changes I requested in bug 2022179 will propagate up the needed build dependencies.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- I've filed this as an upstream ticket as well: https://github.com/pop-os/keyboard-configurator/issues/107
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #9 from Link Dupont link@sub-pop.net --- Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #10 from Neal Gompa ngompa13@gmail.com ---
%package devel
Summary: Development files for %{name} Requires: %{name} = %{version}-%{release}
%description devel Development files for configuration of System76 keyboard firmware.
This has no file list section, is this intentional? If so, should this be deleted?
%forgesetup %patch0 -p1 %patch1 -p1
This can be "%forgeautosetup -p1" instead.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #11 from Link Dupont link@sub-pop.net --- Fixed!
Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... Fedora review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #12 from Neal Gompa ngompa13@gmail.com --- Package was generated through rust2rpm, simplifying the review considerably.
- Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - executable produced with correct binary subpackage - builds and installs
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
--- Comment #13 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/system76-keyboard-configurator
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Link Dupont link@sub-pop.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2022217
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2022217 [Bug 2022217] Review Request: rust-cascade - Dart-like cascade macro for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-12-11 01:29:54
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2022176 Bug 2022176 depends on bug 2022178, which changed state.
Bug 2022178 Summary: Review Request: rust-system76_ectool - System76 EC tool https://bugzilla.redhat.com/show_bug.cgi?id=2022178
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2022176 Bug 2022176 depends on bug 2022179, which changed state.
Bug 2022179 Summary: Review Request: rust-hidapi - Rust-y wrapper around hidapi https://bugzilla.redhat.com/show_bug.cgi?id=2022179
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2022176 Bug 2022176 depends on bug 2022180, which changed state.
Bug 2022180 Summary: Review Request: rust-i18n-embed - Traits and macros to conveniently embed the output of cargo-i18n into your application binary in order to localize it at runtime https://bugzilla.redhat.com/show_bug.cgi?id=2022180
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2022176 Bug 2022176 depends on bug 2022217, which changed state.
Bug 2022217 Summary: Review Request: rust-cascade - Dart-like cascade macro for Rust https://bugzilla.redhat.com/show_bug.cgi?id=2022217
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org