https://bugzilla.redhat.com/show_bug.cgi?id=1480961
Bug ID: 1480961 Summary: Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Description: File change notification Go language Binding
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1476583
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1476583 [Bug 1476583] Review Request: startdde - Starter of deepin desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- rpmlint:
golang-github-howeyc-fsnotify.src: W: summary-ended-with-dot C File change notification Go language Binding. golang-github-howeyc-fsnotify.src: W: invalid-license fsnotify Authors
It actually is "BSD 3-clause": License: BSD.
I'm very green with go packaging, but afaict the guidelines in https://fedoraproject.org/wiki/PackagingDrafts/Go are all followed.
+ latest version + package name is OK + license is acceptable - license is specified incorrectly, please fix when importing + builds and installs OK + Go guideline draft is followed + %check does not pass but is commented out + BR/R/P look OK
Wouldn't it be better to change the %gotest line to something like: { %gotest %{import_path} } || : so that the failures show up in the logs and it's known what needs fixing?
Package is APPROVED. Please fix license tag when uploading.
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
--- Comment #2 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1476583 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1476583 [Bug 1476583] Review Request: startdde - Starter of deepin desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sztsian@gmail.com Alias| |golang-github-howeyc-fsnoti | |fy
https://bugzilla.redhat.com/show_bug.cgi?id=1480961
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:31:19
--- Comment #4 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org